Conversation
Contributor
Author
|
Sorry I had some trouble with the linter. Hopefully it should be alright now. |
Contributor
Author
|
@stgraber Could you please have another look? :) |
Contributor
Author
|
These pipeline errors seem to be unrelated to my change. |
Member
|
The Code ones need fixing, they're showing static analysis failures on your code. |
…ress of the networks subnet Signed-off-by: Leon Schoch <[email protected]>
…f the networks subnet Signed-off-by: Leon Schoch <[email protected]>
… shadowing Signed-off-by: Leon Schoch <[email protected]>
Signed-off-by: Leon Schoch <[email protected]>
DarkressX
force-pushed
the
expand-forward-target-ip-validator
branch
from
c5a754a to
50348f8
Compare
Contributor
Author
|
The current failures refer to parts that were not modified by me. |
Member
|
Thanks! |
tomponline
added a commit
to canonical/lxd
that referenced
this pull request
Oct 22, 2025
… load balancer backends (from Incus) (#16782) This PR extends target IP address validation for network forwards and load balancer backends to check that the target address is not a network address and not a broadcast address. Inspired by lxc/incus#2555.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #2538