Not gonna lie, this one was quite painful

Oh, LVM seems to be behaving differently, but the behavior didn’t appear on my machine.
Edit: turns out on my machine, the ISO was 4M-aligned…

So two questions come up:

• Should I drop the import > export idempotence or should I rather query the DB for the ISO size? (edit: I found a way to keep idempotence)
• Why in the current code don’t we use the actual volume size in the export rather than the on-disk size?

• Should I drop the import > export idempotence or should I rather query the DB for the ISO size?

• Why in the current code don’t we use the actual volume size in the export rather than the on-disk size?

In the case of an ISO which is write-once, it'd be safe to truncate it to the size we have in the database. For any other volume type, not so much as actual data (GPT table mostly) may have been written all the way at the end of the volume (post-rounding/alignment).

In the case of an ISO which is write-once, it'd be safe to truncate it to the size we have in the database. For any other volume type, not so much as actual data (GPT table mostly) may have been written all the way at the end of the volume (post-rounding/alignment).

Oh I see. But doesn’t it mean that we’re exposing in the API a size that may be wrong? (thinking about vol.config["size"])

Nah, it really looks like vol.config["size"] is only exposed for ISO volumes, correct me if I’m wrong.

I’ll add a commit to patch the command description tomorrow

@bensmrs can you add an API extension for this one?

I’m always confused whether we need an extension or not… Here, clients won’t behave differently (as in: it’s the server that tells whether things worked; the clients don’t have to adapt) with or without this extension, so what’s exactly the point?

@bensmrs sorry, needs a rebase because of the API extension.

I’m always confused whether we need an extension or not… Here, clients won’t behave differently (as in: it’s the server that tells whether things worked; the clients don’t have to adapt) with or without this extension, so what’s exactly the point?

The reason for this one is so for example a web UI can tell whether to show a download button next to that ISO image or not.

Doesn't really matter for the CLI as we had a clear error, but it does allow for providing a better user experience in some situations.

Ok thanks for the clarification