client/oci: Allow OCI image names with a pinned hash#2460
Merged
Conversation
Enables specifying OCI images as `IMAGE:TAG@HASH` Signed-off-by: Angelos Kolaitis <[email protected]>
neoaggelos
force-pushed
the
feat/pin-oci-image-hash
branch
from
533954c to
a0aad16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables specifying OCI images as
IMAGE:TAG@HASHChanges
Previously, attempting to launch an OCI instance with:
$ incus launch docker:kindest/node:v1.33.0@sha256:91e9ed777db80279c22d1d1068c091b899b2078506e4a0f797fbf6e397c0b0b2 test Error: Failed instance creation: Image not foundand incus logs printed
Update incus client logic so that the tag is ignored if a pinned hash is specified, same as
dockerdoes in this situationAfter this change, the instance is launched: