incusd/project: Don't empty global default profile on force deletion#2416
Merged
incusd/project: Don't empty global default profile on force deletion#2416
Conversation
Signed-off-by: David Schneider <[email protected]>
stgraber
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a project has
features.profiles = falseset, the project shares its default profile with the default project. When force-deleting a project (incus project delete --force), its default profile is cleared whether or not the default profile of the deleted project is actually the global default profile.This PR fixes it so that a projects default profile is only emptied, if it actually holds one itself (when
features.profiles = true).