Conversation
github-actions
bot
added
Documentation
stgraber
force-pushed
the
truenas
branch
2 times, most recently
from
03b628d to
c368b22
Compare
mrstux
reviewed
Aug 3, 2025
stgraber
force-pushed
the
truenas
branch
2 times, most recently
from
3cc570e to
12a5eaa
Compare
The loop was problematic, it took a long time, and was sensitive to drivers which require longer to re-activate after a kill The core issue was that if we use >4s then we get good reliability, but we can exceed the 60s timeout window, and thus fail the loop The solution is to try to wait for the PID to be available, rather than hoping it it is available after we wait for a fixed time. This actually results in faster testing, and should be more reliable Signed-off-by: Stuart Espey <[email protected]>
Signed-off-by: Stuart Espey <[email protected]>
Signed-off-by: Jack Bendtsen <[email protected]> Signed-off-by: Stuart Espey <[email protected]>
Signed-off-by: Jack Bendtsen <[email protected]> Signed-off-by: Stuart Espey <[email protected]>
Signed-off-by: Jack Bendtsen <[email protected]> Signed-off-by: Stuart Espey <[email protected]>
Signed-off-by: Jack Bendtsen <[email protected]> Signed-off-by: Stuart Espey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2157