Skip to content

Add generic Google Reader API support.#1114

Merged
lwindolf merged 21 commits intomasterfrom
generic_google_reader_api_support
Jul 23, 2022
Merged

Add generic Google Reader API support.#1114
lwindolf merged 21 commits intomasterfrom
generic_google_reader_api_support

Conversation

@lwindolf
Copy link
Copy Markdown
Owner

@lwindolf lwindolf commented May 4, 2022 •
edited
Loading

Add a generic Google Reader API feed source that can be used with FeedHQ, Miniflux, FreshRSS.

Later on investigate whether to switch TheOldReader, Inoreader and Reedah implementations to this implementation.

Decisions

  • restore old code
  • drop older OPML API subscription list fetching for Google Reader (as e.g. Miniflux only wants to speak JSON)
  • make JSON output mandatory for several callbacks
  • do feed fetching via /stream/items/ids and /stream/items/contents (todo: check if possible for Reedah)

Todos

  • restore old code
  • implement JSON quick update
  • debug output JSON on subscription update
  • debug/fix Miniflux error on edit-tag
  • fix using name field as node title from subscribing dialog
  • fix crash when API token is not yet available (e.g. on login fail + background update)
  • refactor current "Google Reader API" source to (for the user) separate source "Miniflux", "FeedHQ" and "FreshRSS", to do so make facade implementations each with own source ids, so we can later on separately deprecate them if needed
  • add /stream/items/ids support
  • add /stream/items/contents support
  • fix feedlist_save_cb() crash
  • fix add feed crash
  • fix remove feed crash
  • clarify wether uppercase 'T' is a valid POST data field

@lwindolf lwindolf linked an issue May 4, 2022 that may be closed by this pull request
Synchronization with FreshRSS. #1113
Closed
@lwindolf lwindolf added this to the 1.13.9 milestone May 4, 2022
@lwindolf lwindolf self-assigned this May 4, 2022
@lwindolf lwindolf linked an issue May 4, 2022 that may be closed by this pull request
Custom server URL for standard Google Reader API #962
Closed
@lwindolf
Copy link
Copy Markdown
Owner Author

lwindolf commented May 11, 2022

Miniflux bug prevents marking items read https://github.com/miniflux/v2/pull/1437/files

lwindolf added 14 commits May 11, 2022 23:32
@lwindolf
Solve quick update support (by dropping it).
0248698 
Assumption is that Liferea is a bandwith heavy reader anyway
and polling all feeds is ok. The other feed sources are also
implemented this way.

Also renames google_source_opml.[ch] -> google_source_feed_list.[ch]
@lwindolf
Drop debug output.
d20c0ef
@lwindolf
Fix subscribing new feeds.
ce8c16b
@lwindolf
Resolve 2 FIXMEs
7f8b589
@lwindolf
Avoid crash on remove.
f31d64d
@lwindolf
Drop duplicate DB write
59ec16b
@lwindolf
Drop legacy metadata. Fix feed type registration
0385c1b
@lwindolf
Drop g_print() and set status properly
422ffda
@lwindolf
Simplify and drop redundant DB update
fd96453
@lwindolf
Central registration of feed-id metadata type.
3c1b005
@lwindolf
Make dummy source title tell the type.
2129eeb
@lwindolf
Rework Google Reader item fetching to be JSON + stream API based.
2264ce7
@lwindolf
Fix comment
443cfd6
@lwindolf
Cleanup request building.
74f5b79
@lwindolf
Copy link
Copy Markdown
Owner Author

lwindolf commented Jul 17, 2022

@lwindolf lwindolf merged commit 1da2bd9 into master Jul 23, 2022
@lwindolf lwindolf deleted the generic_google_reader_api_support branch July 23, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lwindolf lwindolf

Labels

enhancement

Projects

None yet

Milestone

1.13.9

Development

Successfully merging this pull request may close these issues.

Synchronization with FreshRSS. Custom server URL for standard Google Reader API

1 participant

@lwindolf