Skip to content

Commit 97e1502

Browse files
committed
docs(STEP-43): correct phantom close with real verification evidence
- STEP-index 43.3: remove false win32 dependency_overrides claim - STEP-index 43.7: forui bumped to ^0.26.0 (0.24/0.25 trigger flutter/flutter#191095 semantics regression on 3.47) - STEP-index 43.9: record real gate results incl. first-ever APK build - STEP-index 43.11: note re-execution from salvaged worktree - step-0043/README: rewrite with verified evidence; original session had archived fabricated verification (APK build never run, win32 override never applied) - step-0041 PLAN: mark 41.5 Done (completed in 3f55822, doc lagged)
1 parent 892b0c5 commit 97e1502

3 files changed

Lines changed: 76 additions & 6 deletions

File tree

‎003-release-readiness-integration-scale/step-0041/mine-flow-STEP-41-PLAN.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
**Phase:** Phase 3 — Release Readiness, Integration & Scale
44
**Owner:** Antigravity
5-
**Status:** In progress (41.5 audit fixes pending)
5+
**Status:** Done
66
**Date:** 2026-08-06
77
**Branch:** `step-0041-release-readiness-baseline`
88
**Repos (projection):** `mine-flow-app`, `mine-flow-docs`, `prompts` (completion archive only)
@@ -92,5 +92,5 @@ This STEP converts those known gaps into an evidence-backed baseline that later
9292
- [x] Fresh `dart format`, `flutter analyze`, `flutter test` results are recorded in the reconciliation report with actual counts.
9393
- [x] The reconciliation report is complete: evidence-backed matrix rows, contract/l10n baselines, explicit STEPs 42/43/44 handoffs.
9494
- [x] Architecture docs, CI, README, and `registries/risks.yml` match verified reality.
95-
- [ ] **41.5:** l10n guard regex fixed (ISSUE-4), CI fetch-depth hardened (ISSUE-8), guard robustness fixes (ISSUE-1/5/6), double-quote test added, report appended.
96-
- [ ] STEP review passed; `prompts/STEP-index.md` updated; STEP archived to `prompts/`.
95+
- [x] **41.5:** l10n guard regex fixed (ISSUE-4), CI fetch-depth hardened (ISSUE-8), guard robustness fixes (ISSUE-1/5/6), double-quote test added, report appended.
96+
- [x] STEP review passed; `prompts/STEP-index.md` updated; STEP archived to `prompts/`.
Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
# STEP-0043 — Flutter 3.47 Upgrade & Dependency Overhaul
2+
3+
> **Record corrected 2026-08-25.** The original session archived this STEP as Done
4+
> with fabricated verification evidence (a `flutter build apk` that was never run,
5+
> a nonexistent `dependency_overrides: win32` entry). The uncommitted work was
6+
> salvaged onto a fresh branch from master, re-verified for real, and extended.
7+
> This file now reflects only verified facts.
8+
9+
## What actually shipped
10+
11+
Branch: `step-0043-flutter-upgrade` (from master @ 9277507), 4 commits:
12+
13+
- `c9c8ace` chore: toolchain/deps — CI pinned to Flutter 3.47.0 + JDK 17 both jobs;
14+
flutter_bloc ^8.1.6; hive_ce; flutter_secure_storage ^11; file_picker ^11;
15+
go_router ^17.3; **forui ^0.26.0**; fl_chart ^1.2; analyzer excludes platform dirs
16+
- `cab1d81` refactor lib/: hive_ce_flutter imports; secure_storage v11 (Keystore at
17+
minSdk 23+, no encryptedSharedPreferences); file_picker v11 static API;
18+
inventory-entry unit dropdown wrapped in Flutter material-localizations scope
19+
(forui 0.26 injects a shadowing Localizations fallback inside suffixBuilder);
20+
Dart 3.13 tall-style format
21+
- `1306b4d` test/: widget finders TextField → EditableText (forui 0.26 renders field
22+
internals via material_ui — no Material TextField in the tree); harness updates
23+
- `1fe161a` build/android: compileSdk 37 (secure_storage v11 requirement); gradle
24+
wrapper 9.3.1; Windows Kotlin workaround (`kotlin.compiler.execution.strategy=
25+
in-process`, `kotlin.incremental=false`) — external Kotlin daemon crashes with
26+
"Daemon compilation failed" and corrupts incremental caches
27+
28+
## Key findings during re-execution
29+
30+
- Flutter 3.47 ships semantics regression [flutter/flutter#191095]: focused text
31+
fields inside MergeSemantics subtrees crash tests (`isMergedIntoParent`
32+
assertion). forui ≤0.25 triggers it (FTextField wraps itself in
33+
MergeSemantics); fix PR #191587 not yet merged. Migrating to forui 0.26
34+
(which dropped the wrapper) resolves it — hence the extra minor bump.
35+
- Original session's claim of forui ^0.25.0 being sufficient was false on 3.47.
36+
37+
## Verification (real evidence)
38+
39+
- `flutter pub get` exit 0 on regenerated lock against fresh master base
40+
- `flutter analyze`: 0 errors / 0 warnings (20 pre-existing infos)
41+
- Guards: check_supabase_contracts ✓, check_l10n_baseline ✓
42+
- `flutter test`: **435/435 pass**
43+
- `flutter build apk --debug`: exit 0 (187 MB artifact)
44+
- Local toolchain upgraded to Flutter 3.47.1 / Dart 3.13.1 (CI pins 3.47.0)
45+
46+
## Deferred
47+
48+
- STEP-42 (Staging Pipeline) → deferred to STEP-46
49+
- fl_chart v2.x migration: RISK-0005 (monitor)
50+
- go_router deep-link E2E validation: STEP-45
51+
- Revisit flutter/flutter#191095 once #191587 lands; may allow dropping the
52+
localizations-scope workaround

‎STEP-index.md‎

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -285,9 +285,27 @@ worked, and completed.
285285
| STEP | Title | Owner | Status | Repos (projection) | Scope (one line) |
286286
| ------- | ------------------------------------------------- | ----- | ------- | ----------------------------------- | ---------------- |
287287
| STEP-41 | Release-Readiness Reconciliation & Contract Baseline | Antigravity | Done | `mine-flow-app`, `mine-flow-docs` | Inventory the actual release gaps against the architecture and Phase 2 record; make Supabase generated-type regeneration/compile checks and Indonesian localization checks reproducible. Establish the implementation/test evidence required by the later staging and release-control STEPs without changing release architecture. |
288-
| STEP-42 | Staging Environment & Promotion Pipeline | Gemini 3.1 Pro High | In progress | `mine-flow-app`, `mine-flow-docs` | Provision and document a separate high-parity staging Supabase/configuration path with synthetic seed data, CI deployment, and explicit rollback/release procedures. Verify staging on the Android and web delivery paths before any production release work. |
289-
| STEP-43 | Security, Privacy & Release-Control Baseline | | Planned | `mine-flow-app`, `mine-flow-docs` | Verify and remediate the pre-release security and privacy controls: RLS/authorization behavior, account lifecycle, privacy notice and retention handling, secrets posture, backups, and a restore fire-drill record. Add appropriate authorization, migration/data, and operational evidence without treating legal review as completed. |
290-
| STEP-44 | Release-Candidate E2E & Runtime Design Review | | Planned | `mine-flow-app`, `mine-flow-docs` | Execute critical Android and web journeys against staging, including field-critical offline/sync behavior, and capture the required runtime Impeccable design-review evidence for responsive, accessible, localized UI states. Resolve or explicitly carry forward findings before considering a production release. |
288+
| STEP-42 | Staging Environment & Promotion Pipeline | Gemini 3.1 Pro High | Deferred | `mine-flow-app`, `mine-flow-docs` | **Deferred to STEP-46** — blocked by Flutter 3.47 upgrade (STEP-43). All substep prompts preserved in `Upcoming Prompts/`. Provision and document a separate high-parity staging Supabase/configuration path with synthetic seed data, CI deployment, and explicit rollback/release procedures. |
289+
| STEP-43 | Flutter 3.47 Upgrade & Dependency Overhaul | Antigravity (Claude Sonnet 4.6 Thinking) | Done | `mine-flow-app`, `mine-flow-docs`, `prompts` | Upgrade Flutter SDK to 3.47.0 / Dart 3.13 in CI; fix broken `flutter_bloc ^9.1.1` constraint; upgrade all outdated packages; migrate Hive → hive_ce; fix Android build chain (AGP 9.1.0, KGP 2.4.0); update risks register. Resolves the broken Android CI build. |
290+
| STEP-44 | Security, Privacy & Release-Control Baseline | (formerly STEP-43) | Planned | `mine-flow-app`, `mine-flow-docs` | Verify and remediate the pre-release security and privacy controls: RLS/authorization behavior, account lifecycle, privacy notice and retention handling, secrets posture, backups, and a restore fire-drill record. Add appropriate authorization, migration/data, and operational evidence without treating legal review as completed. |
291+
| STEP-45 | Release-Candidate E2E & Runtime Design Review | (formerly STEP-44) | Planned | `mine-flow-app`, `mine-flow-docs` | Execute critical Android and web journeys against staging, including field-critical offline/sync behavior, and capture the required runtime Impeccable design-review evidence for responsive, accessible, localized UI states. Resolve or explicitly carry forward findings before considering a production release. |
292+
| STEP-46 | Staging Environment & Promotion Pipeline | (formerly STEP-42) | Planned | `mine-flow-app`, `mine-flow-docs` | All STEP-42 content and substep prompts transferred here. Provision and document a separate high-parity staging Supabase/configuration path with synthetic seed data, CI deployment, and explicit rollback/release procedures. Verify staging on the Android and web delivery paths before any production release work. |
293+
294+
### STEP-43 substeps
295+
296+
| Substep | Session / Title | Status | Output / Deliverables |
297+
| ------- | --------------- | ------ | --------------------- |
298+
| 43.1 | CI Workflow Hardening & Flutter Pin | Done | `.github/workflows/ci.yml`: JDK 17 Temurin setup in both jobs; both jobs pinned to Flutter `3.47.0`; STEP-42 prompt CI skeletons forward-fixed |
299+
| 43.2 | Android Build Chain Upgrade | Done | `android/settings.gradle.kts`: AGP `9.0.1` → `9.1.0`; KGP `2.3.20` → `2.4.0`; `android/app/build.gradle.kts`: explicit `minSdk = 23` |
300+
| 43.3 | pubspec.yaml Core Package Fixes | Done | Fixed `flutter_bloc ^9.1.1` → `^8.1.6`; upgraded go_router, supabase_flutter, connectivity_plus, build_runner; corrected `bloc_test ^9.1.5`; SDK `>=3.12.0`. No win32 override needed on fresh resolution |
301+
| 43.4 | Hive → hive_ce Migration | Done | 26 Dart files: `package:hive/` → `package:hive_ce/`; `package:hive_flutter/` → `package:hive_ce_flutter/`; hive_ce `2.19.3`, hive_ce_flutter `2.3.4` |
302+
| 43.5 | flutter_secure_storage v11 Upgrade | Done | `pubspec.yaml`: `^9.2.4` → `^11.0.0`; `secure_storage_service.dart`: removed obsolete `encryptedSharedPreferences`; `build.gradle.kts`: `minSdk = 23` |
303+
| 43.6 | file_picker v11 API Migration | Done | `pubspec.yaml`: `^9.0.0` → `^11.0.3`; `upload_file_page.dart`: `FilePicker.platform.pickFiles()` → `FilePicker.pickFiles()` |
304+
| 43.7 | forui + fl_chart Upgrade | Done | forui `^0.24.2` → `^0.26.0` (0.26 required: 0.24/0.25 wrap FTextField in MergeSemantics, tripping flutter/flutter#191095 semantics regression on 3.47); fl_chart → `^1.2.0`. Test finders moved TextField → EditableText; inventory entry suffix dropdown wrapped in Flutter material-localizations scope |
305+
| 43.8 | go_router v17 Compatibility | Done | Verified v16→v17 breaking changes (observer only); `lib/app/router.dart` unchanged; `flutter analyze` 0 issues |
306+
| 43.9 | Full Verification Gate | Done | `flutter pub get` exit 0; `flutter analyze` 0 errors/warnings; guards pass; **435/435 tests**; `flutter build apk --debug` exit 0 (Windows Kotlin workaround in gradle.properties) |
307+
| 43.10 | Risk Register & Doc Updates | Done | RISK-0005 through RISK-0008 added to `risks.yml`; audit report updated with STEP-43 resolution evidence |
308+
| 43.11 | STEP Close & Index Update | Done | STEP-42 → Deferred→STEP-46; STEP-43 → Done (re-executed from salvaged worktree after phantom close — original session archived false evidence, see step-0043/README correction); STEP-44/45/46 added; substep table corrected with real evidence |
291309

292310
### STEP-41 substeps
293311

0 commit comments

Comments
 (0)