Skip to content

Commit d1f34a3

Browse files
authored
[bugfix](inverted index)temporary disable skip read column data if it match inverted index (apache#18065)
The optimization for skip reading column data if it match inverted index and only used in WHERE clause may get wrong result for complex SQL. This PR temporary disable the optimization and later PRs will resolve the problem fundamentality.
1 parent dc7b201 commit d1f34a3

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

‎be/src/olap/rowset/segment_v2/segment_iterator.cpp‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -852,13 +852,7 @@ Status SegmentIterator::_apply_inverted_index_on_block_column_predicate(
852852
}
853853

854854
bool SegmentIterator::_need_read_data(ColumnId cid) {
855-
int32_t unique_id = _schema.unique_id(cid);
856-
if (_need_read_data_indices.count(unique_id) > 0 && !_need_read_data_indices[unique_id] &&
857-
_output_columns.count(unique_id) < 1) {
858-
VLOG_DEBUG << "SegmentIterator no need read data for column: "
859-
<< _opts.tablet_schema->column_by_uid(unique_id).name();
860-
return false;
861-
}
855+
// TODO(xk) impl right logic
862856
return true;
863857
}
864858

0 commit comments

Comments
 (0)