fix(redaction): bound XML attribute scanning by luvs01 · Pull Request #691 · luvs01/opencodex

luvs01 · 2026-09-30T02:54:09Z

Motivation

A newly introduced full-terminal redaction path exposed untrusted assistant output to a suffix-searching XML-attribute regex that can exhibit quadratic CPU cost on repeated unterminated tags and thereby block the event loop.

Description

Replace the quadratic identifying-attribute regex with a single-pass tag scanner (maskXmlIdentifyingAttribute) that scans each tag once and preserves the folded matching and original-offset mapping used by foldForMatching.
Integrate the new scanner into the framing pass by calling it from maskOtherFramings so credential masking is still applied for XML attribute and tag-name framings.
Keep existing credential-masking semantics (tag-name, name|key|id attributes, multipart, colon-labelled, and value patterns) while avoiding repeated suffix lookahead over unterminated tags.
Add a bounded-time regression test tests/lib/redact.test.ts that asserts repeated unterminated tags (e.g. "<a ".repeat(8000)) are scanned in bounded time and unchanged when not credential-bearing.

Testing

Ran focused unit suites with ./node_modules/.bin/bun test tests/lib/redact.test.ts tests/responses/responses-canonical-nonstream.test.ts tests/responses/sse-failed-tail.test.ts and observed the focused runs pass (139 passed, 0 failed).
Ran type checking with bun x tsc --noEmit, structure verification with bun run structure:check, and privacy scan with bun run privacy:scan, all of which completed successfully for the modified areas.
Ran git diff --check to confirm no whitespace/patch issues; the full repository test run was not used to gate this focused fix because some unrelated integration tests failed in this checkout; the redaction- and delivery-focused tests and typecheck passed.

Codex Task

Summary by CodeRabbit

Bug Fixes
- Improved credential redaction in XML, including credentials identified by tag names or attributes.
Tests
- Added a regression test covering large inputs with unterminated, non-credential tags.

coderabbitai · 2026-09-30T02:54:17Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: luvs01/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 69069649-9e8e-43d8-9039-f4ebb2c02c4e

📥 Commits

Reviewing files that changed from the base of the PR and between d4480b7 and f42e713.

📒 Files selected for processing (2)

src/lib/redact.ts
tests/lib/redact.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

XML credential redaction now uses a separate scanner to check tag attributes in decoded and raw input. A performance regression test covers repeated unterminated tags that do not contain credential labels.

Changes

XML credential redaction

Layer / File(s)	Summary
XML attribute scanning and validation `src/lib/redact.ts`, `tests/lib/redact.test.ts`	The general XML framing rule for credential-valued `name`, `key`, or `id` attributes was removed. A separate scanner checks XML tag attributes in decoded and raw input. When an attribute matches a credential label, it preserves the text through the tag name and masks the rest of the input. The regression test checks that 8,000 repeated unterminated non-credential tags remain unchanged and complete in under 1,000 ms.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: lidge-jun, ingwannu

Merge Risk: ⚪ Minimal · up to f42e7

The XML scanning change addresses repeated unterminated tags while retaining credential masking. No actionable issue prevents merging after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely describes the main change: bounding XML attribute scanning in the redaction logic to avoid quadratic behavior.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-30T02:54:23Z

✅ Deterministic PR hygiene checks passed.

devin-ai-integration

Devin Review found 1 potential issue.

devin-ai-integration · 2026-09-30T02:56:29Z

+    const started = performance.now();
+    expect(redactSecretString(input)).toBe(input);
+    expect(performance.now() - started).toBeLessThan(1_000);


🔍 Fixed timing threshold may make the regression test flaky

The 1,000 ms limit measures the entire redaction pipeline. A busy CI worker could fail it even when XML scanning remains linear; consider comparing input-size scaling instead.

Was this helpful? React with 👍 or 👎 to provide feedback.

luvs01 · 2026-09-30T09:19:26Z

@coderabbitai review

coderabbitai · 2026-09-30T09:19:36Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

* fix(redaction): bound XML identifying-attribute scans Carry luvs01#691 at f42e713. Replace wall-clock regression with delimiter-work accounting and preserve malformed/escaped credential coverage. * fix(redaction): recognize quoted XML tag delimiters Scan tag terminators outside quoted values, cover credential masking after embedded delimiters, and count manual character work in linear-scaling regressions.

fix(redaction): bound XML attribute scanning

f42e713

luvs01 added codex aardvark labels Sep 30, 2026 — with ChatGPT Codex Connector

github-actions Bot added the bug Something isn't working label Sep 30, 2026

devin-ai-integration Bot reviewed Sep 30, 2026

View reviewed changes

luvs01 mentioned this pull request Sep 30, 2026

fix(redaction): bound XML identifying-attribute scans lidge-jun/opencodex#6325

Merged

4 of 5 tasks

luvs01 closed this Sep 30, 2026

github-actions Bot deleted the codex/investigate-vulnerability-in-opencodex branch October 15, 2026 11:52

Navigation Menu

Repository navigation

fix(redaction): bound XML attribute scanning - #691

fix(redaction): bound XML attribute scanning#691
luvs01 wants to merge 1 commit into
devfrom
codex/investigate-vulnerability-in-opencodex

luvs01 commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

devin-ai-integration Bot Sep 30, 2026

Uh oh!

luvs01 commented Sep 30, 2026

Uh oh!

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

luvs01 commented Sep 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Description

Testing

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Sep 30, 2026

Choose a reason for hiding this comment

Uh oh!

luvs01 commented Sep 30, 2026

Uh oh!

coderabbitai Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

luvs01 commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading