@@ -296,11 +296,9 @@ function coderabbitOutsideDiffFindings({ reviews = [], liveHeadSha }) {
296296 * only in its review body (outside the diff range); those are added by the
297297 * `coderabbitOutsideDiffFindings` supplement so they cannot slip through.
298298 * The supplement is subordinate: it never subtracts, only adds unresolved
299- * counts for the live head while a bot thread is still open. A review body is
300- * immutable, so the count can never fall to zero on its own once posted; the
301- * supplement therefore only counts while an unresolved bot thread exists — the
302- * author resolves that thread to clear the box, matching the checklist wording
303- * ("I resolved all correct ... findings") without requiring an empty commit.
299+ * counts for the live head. Review-body-only findings must be checked even when
300+ * CodeRabbit did not create a review thread; otherwise those findings would
301+ * have no signal capable of keeping the checklist claim unticked.
304302 */
305303function unresolvedFindingsClaim ( { threads = [ ] , reviews = [ ] , liveHeadSha } ) {
306304 const byBot = { } ;
@@ -313,13 +311,11 @@ function unresolvedFindingsClaim({ threads = [], reviews = [], liveHeadSha }) {
313311 unresolved += 1 ;
314312 }
315313 }
316- if ( unresolved > 0 ) {
317- const outside = coderabbitOutsideDiffFindings ( { reviews, liveHeadSha } ) ;
318- if ( outside . code ) {
319- for ( const [ login , count ] of Object . entries ( outside . byBot ) ) {
320- byBot [ login ] = ( byBot [ login ] ?? 0 ) + count ;
321- unresolved += count ;
322- }
314+ const outside = coderabbitOutsideDiffFindings ( { reviews, liveHeadSha } ) ;
315+ if ( outside . code ) {
316+ for ( const [ login , count ] of Object . entries ( outside . byBot ) ) {
317+ byBot [ login ] = ( byBot [ login ] ?? 0 ) + count ;
318+ unresolved += count ;
323319 }
324320 }
325321 return unresolved > 0
0 commit comments