fix: adler32's first 16-bit should default to 1 not 0#294
Merged
zhaozg merged 1 commit intoluvit:masterfrom Aug 20, 2024
Merged
fix: adler32's first 16-bit should default to 1 not 0#294zhaozg merged 1 commit intoluvit:masterfrom
zhaozg merged 1 commit intoluvit:masterfrom
Conversation
Contributor
Author
|
Failed tests are unrelated. |
zhaozg
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the default value for the first parameter of
lminiz.adler32will output invalid checksum due to improper defaults.For example:
Which is wrong, it should instead be
110953013(0x069D0235).For reference take the output of an online calculatore like this one or even the Wikipedia example.
An Adler32 checksum is 32-bit number made of two 16-bit groups A and B, group A should initiate with
1and group B should initiate with0. Currently by default group A will default to0instead of1.@zhaozg Is this right?