various fixes for building with shared libraries#291
Merged
squeek502 merged 1 commit intoluvit:masterfrom Jul 23, 2024
Merged
Conversation
- adds a CI check for all shared libraries to ensure they don't regress
Contributor
|
A Luvi release is blocked until this is merged. Seems mostly good to me, be it some parts are confusing as I don't fully understand the build scripts. |
squeek502
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also adds a CI check for building with all shared libraries to ensure they don't regress
Most of these regressions were introduced in #285 as a result of not being covered by CI
Primarily focused on fixing #280