move all CI to Actions, overhaul build system, upgrade ancient dependencies#285
Merged
zhaozg merged 11 commits intoluvit:masterfrom Jul 4, 2024
Merged
move all CI to Actions, overhaul build system, upgrade ancient dependencies#285zhaozg merged 11 commits intoluvit:masterfrom
zhaozg merged 11 commits intoluvit:masterfrom
Conversation
This is an amalgamation of many changes: - remove make.bat, use nmake compatible Makefile instead - remove appveyor.yml, use exclusively GitHub Actions - reorganize the cmake build to make use of new features - configure openssl during the configure step - make dependencies more consistent - always use luac.lua to compile lua files - this makes a static luvi build more possible
Member
|
Awesome stuff! Probably worth giving the I've tried disabling Appveyor for PRs so that failure might go away on the next CI run. Will disable Appveyor completely when this is going to be merged. |
zhaozg
approved these changes
Jul 4, 2024
Member
Author
squeek502
approved these changes
Jul 4, 2024
Member
squeek502
left a comment
squeek502
left a comment
There was a problem hiding this comment.
Really great work, feel free to merge this whenever you think it's ready. The Appveyor CI should be disabled now.
Member
@truemedian maybe without merge rights, If you finish, please let @luvit/luvit-admin team do that, and thank you for great work. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a large set of changes that accomplishes a few different goals all at the same time.
With these changes, we:
Alongside this change, all CI is now handled on Github Actions instead of being split between Actions and appveyor.
The makefile and make.bat have been moved into a single make and nmake compatible makefile. While it makes the makefile slightly more complicated, I felt that the distinction was necessary now that mingw builds are possible and make.bat would always attempt a msvc build.
The cmake Find* modules have all been cleaned up and commented.
All precompiled lua files are now precompiled using luac.lua instead of luajit's object output, it was causing issues on arm64 Darwin and it's much more simple to handle PUC and Luajit the same here.
The luv package has also been added to package.preload as
luvin order to be more compatible with what luarocks packages may expect.