Ensure that using the -v or -h flags always returns with EXIT_SUCCESS#255
Merged
zhaozg merged 1 commit intoluvit:masterfrom Oct 22, 2021
LuvitPlayground:fix-cli-return-code
Merged
Ensure that using the -v or -h flags always returns with EXIT_SUCCESS#255zhaozg merged 1 commit intoluvit:masterfrom LuvitPlayground:fix-cli-return-code
zhaozg merged 1 commit intoluvit:masterfrom
LuvitPlayground:fix-cli-return-code
Conversation
Returning -1 indicates an error, assuming the usual convention for exit codes is followed. Seeing how main.c returns -1 in case of errors, this appears to be the case. Specifically, using either of the two flags in a script or CI workflow will cause it to mistakenly assume an error has occured and fail as a result.
squeek502
approved these changes
Oct 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning
-1indicates an error, assuming the usual convention for exit codes is followed. Seeing howmain.creturns-1in case of errors, this appears to be the case. Edit: It seems to turn into255on my Ubuntu system, but that's still interpreted as an error.Specifically, using either of the two flags in a script or CI workflow will cause it to mistakenly assume an error has occured and fail as a result. I've found this out when I was using
-vin a workflow (for debugging purposes) and it failed the entire run.