Merged
Conversation
…pt modification later.
Also renamed a method to make it more clear what it does.
… CMBFileHandler level
…ad of bytes. This should also allow for chest randomization in Ch. 7.
lushen124
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #232 - Added logic to read and rebuild the CMB script file more intelligently and decodes the scripting instructions. This allows Yune to randomize rewards properly by replacing instructions instead of searching for specific byte patterns. This re-enables chest randomization for Ch. 7 and probably causes less issues with scripting overall for the rest of the code and opens the door to fix more scripting issues.