GBAFE: Random movement does not use maximum shown in UI#261
Merged
lushen124 merged 3 commits intolushen124:masterfrom Aug 25, 2020
Merged
GBAFE: Random movement does not use maximum shown in UI#261lushen124 merged 3 commits intolushen124:masterfrom
lushen124 merged 3 commits intolushen124:masterfrom
Conversation
Side benefit of resolving a potential crash if user inputs equal values for min and max movement
sbeach
changed the title
Contributor
Author
|
If you want the test package stuff removed it will make me sad, but I will understand. Side note, the JARs are in a new |
Owner
|
I had plans at one point to write tests, but I never got around to it. Tests are always nice to have. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #259
Random.nextInt(bound)excludesboundas a potential option and instead returns the floor of the calculated value. Thus if a user inputs 8 as Max MOV, 7 will be the true maximum after randomization.