[Issue #166] Fixed FE8 minion identification.#213
Merged
Conversation
Improved the weapon upgrade by allowing the same rank weapons with higher might as upgrades.
# Conflicts: # Universal FE Randomizer/src/random/gba/randomizer/EnemyBuffer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #166 - Fixed an issue where FE8 minions were not being identified correctly. We now use the combination of the enemy flag and the autolevel flag to determine minions. The original logic still exists to make sure FE6 and FE7 don't break, but we've added a second possible condition to cover FE8.
Also improved the weapon upgrade by allowing the same rank weapons with higher might as upgrades. This is most obvious with Steel Axes, which are technically rank E, but should be considered an upgrade over Iron Axes, even though it doesn't increase in rank.