[Issue #176] Reduced maximum durability for GBAFE#210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #176 - Updated the maximum weapon durability selectable for GBAFE to be 63. This is due to a limitation of the save format for GBAFE games. They seem to only use 6 bits to save durability information for weapons in the save data. This means that any weapon that attempts to save its durability will have its most significant 2 bits cut off. Based on empirical testing, 6 bits seems to be saved, as a 99 durability weapon, when saved, will load as having 35 durability. (99 is 0x63 in hex. If you truncate the two most significant bits, you get 0x23, which is 35 in decimal.)