Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #181 - Reworked the autoleveling routine for randomized recruitment in GBAFE. The previous logic didn't quite calculate the changes correctly when jumping between promoted and unpromoted classes. The new one takes a more logical approach by operating with effective values instead of strictly the character bases.
This does change a little bit for Karel in a specific case. The existing reverse recruitment patch balanced Karel a bit by starting him with 8 HP, 2 STR, and 5 SKL specifically. Given his growths, there's no natural mathematical way of getting this. So instead of coming up with stats for each possible place he could be recruited at, the logic now just ensures that HP, for any character, can never be below 10 HP (this is so they don't die immediately when entering combat). On the flip side, all of the other stats are allowed to start at 0 instead of an arbitrary minimum value.
Also fixed a random issue where FE8 trainees being randomized into a promoted unit's spot would only promote to the tier 1 class instead of a tier 2 class.