Skip to content

[Growth] Remove launch-kit npm checklist references#226

Merged
luoyuctl merged 1 commit into
masterfrom
growth/223-launch-kit-npm-cleanup
May 19, 2026
Merged

[Growth] Remove launch-kit npm checklist references#226
luoyuctl merged 1 commit into
masterfrom
growth/223-launch-kit-npm-cleanup

Conversation

@luoyuctl

@luoyuctl luoyuctl commented May 19, 2026

Copy link
Copy Markdown
Owner

Closes #223

Summary

  • Remove stale npm package file references from the launch-kit release checklist.
  • Extend the release-surface guard to scan docs/launch-kit.md for npm package/wrapper regressions.

User-facing value

Release checklist readers no longer see deleted npm package surfaces as part of the current install story.

Adoption rationale

Keeping launch and release docs aligned with the supported install paths avoids sending new users or maintainers toward unavailable package surfaces.

Scope

  • Docs checklist cleanup only for the stale launch-kit npm references.
  • CI guard coverage for the same launch-kit surface.
  • No tag, GitHub Release, package publish, npm publish, Homebrew publish, external posting, or unrelated workflow changes.

Test plan

  • git diff --check
  • go test ./...
  • go build -o /tmp/agenttrace-growth-check ./cmd/agenttrace
  • /tmp/agenttrace-growth-check --doctor
  • scripts/ci/check-release-surfaces.sh
  • AGENTTRACE_BIN=/tmp/agenttrace-growth-check AGENTTRACE_CI_OUT=/tmp/agenttrace-growth-ci scripts/ci/check-docs-commands.sh
  • scripts/ci/check-pages-artifact.sh site
  • AGENTTRACE_BIN=/tmp/agenttrace-growth-check AGENTTRACE_CI_OUT=/tmp/agenttrace-growth-ci scripts/ci/check-output-contract.sh
  • AGENTTRACE_BIN=/tmp/agenttrace-growth-check AGENTTRACE_CI_OUT=/tmp/agenttrace-growth-ci scripts/ci/check-deterministic-output.sh
  • AGENTTRACE_BIN=/tmp/agenttrace-growth-check AGENTTRACE_CI_OUT=/tmp/agenttrace-growth-ci scripts/ci/check-report-semantics.sh
  • markdownlint README.md docs/**/*.md || true attempted; unavailable locally (markdownlint: command not found)

Safety checklist

@luoyuctl luoyuctl mentioned this pull request May 19, 2026
Closed
@luoyuctl luoyuctl added lane/growth Adoption and distribution work status/ready-for-review Ready for review labels May 19, 2026
@luoyuctl

luoyuctl commented May 19, 2026

Copy link
Copy Markdown
Owner Author

Quality Gatekeeper Review

Verdict: PASS
Risk: Low
Lane: growth

Checks:

  • One logical change
  • Scope is clear
  • Protected files unchanged or explicitly scoped by Remove npm package surfaces after package-channel decision #223 residual-cleanup allowance
  • No secret/session/prompt leakage observed
  • No public platform-attention target wording observed
  • GitHub mergeStateStatus: CLEAN
  • GitHub CI Test and build: SUCCESS
  • go test ./... passed
  • go build passed
  • doctor/demo overview passed
  • Docs/release-surface checks updated as needed

Evidence commands run:

  • gh issue list --repo luoyuctl/agenttrace --limit 1000
  • gh pr list --repo luoyuctl/agenttrace --state open --limit 1000
  • gh pr list --repo luoyuctl/agenttrace --state closed --limit 50
  • gh issue list --repo luoyuctl/agenttrace --label "lane/quality" --label "status/ready-for-agent" --limit 1000
  • gh pr list --repo luoyuctl/agenttrace --state open --search "label:status/ready-for-review" --limit 1000
  • gh repo view luoyuctl/agenttrace --json stargazerCount,defaultBranchRef
  • gh pr view 226 --repo luoyuctl/agenttrace --json number,title,state,isDraft,headRefName,headRefOid,baseRefName,mergeStateStatus,mergeable,labels,files,statusCheckRollup,comments,closingIssuesReferences,body,author
  • gh pr checks 226 --repo luoyuctl/agenttrace
  • gh pr diff 226 --repo luoyuctl/agenttrace --name-only
  • gh pr diff 226 --repo luoyuctl/agenttrace | rg -i "(secret|api[_-]?key|private key|token|prompt|session|NPM_PUBLISH_ALLOWED|npm publish|github release|homebrew|VERSION|PRIVACY|SECURITY|LICENSE|npm/|npm install|wrapper|prepared|docs/launch-kit|launch-kit|workflow|permissions|secrets)"
  • git fetch origin pull/226/head:pr-226
  • git status --short --branch
  • go test ./...
  • go build -o /tmp/agenttrace-review-pr-226 ./cmd/agenttrace
  • go vet ./...
  • bash -n scripts/record-demo.sh scripts/ci/*.sh
  • ruby -c homebrew/Formula/agenttrace.rb
  • /tmp/agenttrace-review-pr-226 --doctor || true
  • /tmp/agenttrace-review-pr-226 --demo --overview -f json
  • scripts/ci/check-release-surfaces.sh
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-226 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-226-ci scripts/ci/check-docs-commands.sh
  • scripts/ci/check-pages-artifact.sh site
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-226 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-226-ci scripts/ci/check-output-contract.sh
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-226 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-226-ci scripts/ci/check-deterministic-output.sh
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-226 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-226-ci scripts/ci/check-report-semantics.sh
  • git diff --check
  • test -z "$(gofmt -l .)"
  • rg -n "npm/package.json|npm/README.md|npm install -g agenttrace|AGENTTRACE_RELEASE_TAG|npm wrapper|npm package" docs/launch-kit.md README.md CONTRIBUTING.md CHANGELOG.md site homebrew scripts || true
  • git ls-files "npm/*"

Current reviewed state:

Decision:
PASS. This is a focused residual cleanup after #225: it removes deleted npm package file references from the launch-kit checklist and extends the release-surface guard to cover docs/launch-kit.md. The only remaining npm-related grep hits are in the guard itself. No npm wrapper files are tracked.

Label action after merge: add status/auto-merged; remove status/ready-for-review.

Handoff to: Growth
User-facing release checklist cleanup will land after merge. No tag, GitHub Release, package publish, npm publish, Homebrew publish, external posting, secret handling, permission expansion, or unrelated workflow refactor is included.

@luoyuctl luoyuctl merged commit f8f0fed into master May 19, 2026
1 check passed
@luoyuctl luoyuctl deleted the growth/223-launch-kit-npm-cleanup branch May 19, 2026 16:53
@luoyuctl

luoyuctl commented May 19, 2026

Copy link
Copy Markdown
Owner Author

Quality Gatekeeper Review

Verdict: PASS
Risk: Medium
Lane: growth

Checks:

  • One logical change
  • Scope is clear
  • Protected-file exception is limited to the Remove npm package surfaces after package-channel decision #223 residual cleanup now allowed by current Quality rules
  • No secret/session/prompt leakage observed
  • No public platform-attention target wording observed
  • GitHub mergeStateStatus: CLEAN
  • GitHub CI Test and build: SUCCESS
  • go test ./... passed
  • go build passed
  • doctor/demo overview passed
  • Docs/tests/release-surface checks updated as needed

Evidence commands run:

  • gh repo view luoyuctl/agenttrace --json stargazerCount,defaultBranchRef
  • gh issue list --repo luoyuctl/agenttrace --limit 1000
  • gh pr list --repo luoyuctl/agenttrace --state open --limit 1000
  • gh pr list --repo luoyuctl/agenttrace --state closed --limit 50
  • gh issue list --repo luoyuctl/agenttrace --label "lane/quality" --label "status/ready-for-agent" --limit 1000
  • gh pr list --repo luoyuctl/agenttrace --state open --search "label:status/ready-for-review" --limit 1000
  • gh pr view 226 --repo luoyuctl/agenttrace --json number,title,state,isDraft,headRefName,headRefOid,baseRefName,mergeStateStatus,labels,statusCheckRollup,reviewDecision,updatedAt,author,body,files,comments,closingIssuesReferences
  • gh pr checks 226 --repo luoyuctl/agenttrace
  • gh pr diff 226 --repo luoyuctl/agenttrace --name-only
  • gh issue view 223 --repo luoyuctl/agenttrace --json number,state,labels,comments,updatedAt
  • git fetch origin pull/226/head:pr-226
  • git worktree add ../agenttrace-review-pr-226 pr-226
  • git diff --stat origin/master...HEAD && git diff --name-status origin/master...HEAD
  • git diff origin/master...HEAD -- docs/launch-kit.md scripts/ci/check-release-surfaces.sh
  • rg -n "npm/package.json|npm/README.md|npm install -g agenttrace|AGENTTRACE_RELEASE_TAG|npm wrapper|prepared npm|npm package" README.md CONTRIBUTING.md CHANGELOG.md docs site homebrew .github scripts || true
  • gh pr diff 226 --repo luoyuctl/agenttrace | rg -i "(secret|api[_-]?key|private key|token|prompt|session|NPM_PUBLISH_ALLOWED|npm publish|github release|homebrew|VERSION|PRIVACY|SECURITY|LICENSE|permissions:|contents: write|id-token|release|tag)"
  • go test ./...
  • go build -o /tmp/agenttrace-review-pr-226 ./cmd/agenttrace
  • git diff --check origin/master...HEAD
  • test -z "$(gofmt -l .)"
  • go vet ./...
  • scripts/ci/check-release-surfaces.sh
  • /tmp/agenttrace-review-pr-226 --doctor || true
  • /tmp/agenttrace-review-pr-226 --demo --overview -f json
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-226 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-226-ci scripts/ci/check-docs-commands.sh
  • scripts/ci/check-pages-artifact.sh site
  • bash -n scripts/record-demo.sh scripts/ci/*.sh && ruby -c homebrew/Formula/agenttrace.rb
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-226 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-226-ci scripts/ci/check-output-contract.sh
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-226 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-226-ci scripts/ci/check-deterministic-output.sh
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-226 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-226-ci scripts/ci/check-report-semantics.sh

Current reviewed state:

  • Head: af7e416b3ac4723951f0687aa54b8b75ab9b1a63
  • Linked Issue: Remove npm package surfaces after package-channel decision #223
  • Changed files: docs/launch-kit.md and scripts/ci/check-release-surfaces.sh
  • Diff removes stale references to deleted npm/package.json and npm/README.md, and extends release-surface scanning to docs/launch-kit.md.

Decision:
PASS. This is a focused follow-up to the reopened #223 residual cleanup. It removes the stale launch-kit npm checklist reference and adds guard coverage for that file. No tag, GitHub Release, package publish, npm publish, Homebrew publish, external posting, secret handling, permission expansion, or unrelated workflow/docs refactor is included.

Label action after merge: remove status/ready-for-review; add status/auto-merged.

Handoff to: Growth
The remaining user-visible cleanup is launch/release checklist wording only. Future release notes may mention the unavailable npm wrapper path removal if notes are generated from merged PRs.

This was referenced May 19, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lane/growth Adoption and distribution work status/auto-merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove npm package surfaces after package-channel decision

1 participant

@luoyuctl