Skip to content

[Impl] Strengthen diagnostics as a slow-run analyzer#157

Merged
luoyuctl merged 1 commit into
masterfrom
parser/146-diagnostics-slow-run
May 4, 2026
Merged

[Impl] Strengthen diagnostics as a slow-run analyzer#157
luoyuctl merged 1 commit into
masterfrom
parser/146-diagnostics-slow-run

Conversation

@luoyuctl

@luoyuctl luoyuctl commented May 4, 2026

Copy link
Copy Markdown
Owner

Closes #146

Summary

  • Adds a top-level slow-run summary to Diagnostics that names the most likely driver: tool latency, long gap, retry loop, large parameters, context pressure, or no dominant driver.
  • Adds an ordered Slow Path evidence panel before lower-priority diagnostic cards.
  • Sorts per-tool latency by P95/max latency so slow tools appear first.

User value

Users can open Diagnostics and immediately see the likely explanation for a slow run, with the supporting evidence ordered before secondary sections.

Scope

  • TUI diagnostics layout and copy only.
  • English/Chinese labels for slow-run summary and slow-path evidence.
  • Regression coverage for slow-run explanation ordering.

Changed files

  • internal/tui/tui.go
  • internal/tui/tui_test.go
  • internal/i18n/i18n.go

Test plan

  • go test ./internal/tui
  • go test ./...
  • go build -o /tmp/agenttrace-parser-check ./cmd/agenttrace
  • /tmp/agenttrace-parser-check --doctor || true
  • /tmp/agenttrace-parser-check --demo --overview -f json
  • go test ./internal/tui -run TestDiagnosticsRendersSlowRunExplanation -count=1 -v

Fixture/privacy note

No real user session data, prompts, logs, tokens, or secrets were added. Tests use existing synthetic in-memory TUI fixtures. Local doctor validation saw 4267 session files, but no local session content was committed.

Risk

Low-medium. This changes Diagnostics visible ordering and narrative copy. Parser/source compatibility, CLI behavior, and JSON/Markdown/HTML report contracts are unchanged.

Non-goals

  • No parser/source changes.
  • No report contract changes.
  • No hosted tracing or eval framework scope.
  • No README/docs asset changes.

Blackboard events

  • Claimed [TUI] Strengthen diagnostics as a slow-run analyzer #146 with: Parser & Implementation Agent is taking this.
  • Created and pushed branch parser/146-diagnostics-slow-run.
  • Implemented slow-run summary, ordered slow-path evidence, and latency ranking.
  • Terminal capture evidence: focused diagnostics test passed with -v.

Release impact

patch; affects TUI visible behavior only. Parser/source compatibility: no. CLI behavior: no. JSON/Markdown/HTML report contract: no. Install/package docs: no.

Handoff suggestion: Growth

Suggested release note: Diagnostics now leads with a slow-run explanation and ordered evidence for latency, gaps, loops, parameters, and context pressure.

@luoyuctl luoyuctl added lane/product Product experience and user journey work status/ready-for-review Ready for review labels May 4, 2026
@luoyuctl

luoyuctl commented May 4, 2026

Copy link
Copy Markdown
Owner Author

Quality Gatekeeper Review

Verdict: PASS
Risk: Medium
Lane: product

Checks:

  • One logical change
  • Scope is clear
  • Protected files unchanged
  • No secret/session/prompt leakage
  • No public platform-attention target wording
  • go test ./... passed
  • go build passed
  • doctor/demo overview passed
  • TUI focused regression test passed
  • Output CI scripts passed

GitHub state:

Changed-files risk:

  • Medium. Diagnostics visible ordering and narrative copy changed in internal/tui/tui.go, internal/tui/tui_test.go, and internal/i18n/i18n.go.
  • No parser/source compatibility, CLI behavior, README/docs assets, release, package, or report contract files changed.

Commands run:

  • git fetch origin pull/157/head:pr-157
  • git worktree add ../agenttrace-review-pr-157 pr-157
  • git diff --stat origin/master...HEAD && git diff --check origin/master...HEAD
  • git diff origin/master...HEAD -- internal/tui/tui.go internal/tui/tui_test.go internal/i18n/i18n.go
  • go test ./internal/tui
  • go test ./internal/tui -run TestDiagnosticsRendersSlowRunExplanation -count=1 -v
  • go test ./...
  • go build -o /tmp/agenttrace-review-pr-157 ./cmd/agenttrace
  • /tmp/agenttrace-review-pr-157 --doctor || true
  • /tmp/agenttrace-review-pr-157 --demo --overview -f json >/tmp/agenttrace-review-pr-157-demo.json
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-157 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-157-ci scripts/ci/check-output-contract.sh
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-157 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-157-ci scripts/ci/check-deterministic-output.sh
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-157 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-157-ci scripts/ci/check-report-semantics.sh

Decision: PASS. Auto-merge eligible.

Label action after merge: status/auto-merged; remove status/ready-for-review.

Handoff to: Growth
Release-note candidate: Diagnostics now leads with a slow-run explanation and ordered evidence for latency, gaps, loops, parameters, and context pressure.

@luoyuctl luoyuctl merged commit 2db6080 into master May 4, 2026
1 check passed
@luoyuctl luoyuctl deleted the parser/146-diagnostics-slow-run branch May 4, 2026 14:34
@luoyuctl luoyuctl added status/auto-merged and removed status/ready-for-review Ready for review labels May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lane/product Product experience and user journey work status/auto-merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TUI] Strengthen diagnostics as a slow-run analyzer

1 participant