Merged
Conversation
glennjacobs
approved these changes
Dec 23, 2021
glennjacobs
pushed a commit
that referenced
this pull request
Dec 18, 2023
samimhamza
referenced
this pull request
in samimhamza/lunar-ecommerce
Nov 30, 2024
samimhamza
added a commit
to nawawaran/lunar
that referenced
this pull request
Mar 17, 2025
Beaudinn
added a commit
to print4sign/lunar-base
that referenced
this pull request
Jan 12, 2026
…ents This commit addresses 6 important issues identified in the comprehensive code review: Issue lunarphp#1: Artwork URL TTL (60s → 3600s) - Changed temporary URL expiration from 60 seconds to 3600 seconds (1 hour) - Updated HelloPrintDriver::getArtworkUrl() - Updated PrintComDriver::getArtworkUrl() - Prevents premature URL expiration during order submission Issue lunarphp#2: Internal Supplier Seeder Command - Created lunar:seed-internal-supplier artisan command - Registered command in LunarServiceProvider - Makes InternalSupplierSeeder easily runnable without modifying DatabaseSeeder Issue lunarphp#3: Supplier Product Validation - Added validation in HelloPrintDriver::submitOrder() - Added validation in PrintComDriver::submitOrder() - Returns OrderResponse::failed() if variant has no supplier product - Prevents null reference exceptions during order submission Issue lunarphp#4: PrintCom Sandbox Mode - Added sandbox configuration to suppliers.php for PrintCom - Added PRINTCOM_SANDBOX environment variable support - Updated PrintComDriver::submitOrder() to include mode field (test/live) - Matches HelloPrint driver pattern for consistency Issue lunarphp#5: Meta Array Handling - Standardized meta array handling in GetPrintComPrice pipeline - Fixed potential array offset error when meta is null - Properly initializes meta array before setting supplier_pricing Issue lunarphp#6: Foreign Key Indexes - Added explicit indexes for foreign key columns in supplier_orders table - Added indexes for cancellation_requested_by, cancelled_by, approved_by - Improves query performance for user-related lookups - Added corresponding dropIndex calls in migration down() method All changes are backward compatible and include proper test coverage. Tests passing: 50 passed (175 assertions) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various tweaks/fixes to the hub.