Skip to content

Hotfix/fix up variant editing screens#5

Closed
alecritson wants to merge 4 commits intomainfrom
hotfix/fix-up-variant-editing-screens
Closed

Hotfix/fix up variant editing screens#5
alecritson wants to merge 4 commits intomainfrom
hotfix/fix-up-variant-editing-screens

Conversation

@alecritson
Copy link
Collaborator

Changes

  • On the option selector, if you have no options available it would suggest there was no options due to the search term, which is incorrect. This should now clarify why there are no options a bit better.
  • The "add option" button could be easily missed on the option selector, it's now next to the search box.

@glennjacobs
Copy link
Contributor

Can we also update the placeholder text as we discussed? And hide the translation button if only one language set?

image

@alecritson alecritson marked this pull request as draft December 23, 2021 11:45
@alecritson alecritson closed this Dec 23, 2021
@alecritson alecritson deleted the hotfix/fix-up-variant-editing-screens branch December 23, 2021 12:00
@glennjacobs glennjacobs restored the hotfix/fix-up-variant-editing-screens branch December 23, 2021 12:09
samimhamza added a commit to nawawaran/lunar that referenced this pull request Mar 17, 2025
Beaudinn added a commit to print4sign/lunar-base that referenced this pull request Jan 12, 2026
…ents

This commit addresses 6 important issues identified in the comprehensive code review:

Issue lunarphp#1: Artwork URL TTL (60s → 3600s)
- Changed temporary URL expiration from 60 seconds to 3600 seconds (1 hour)
- Updated HelloPrintDriver::getArtworkUrl()
- Updated PrintComDriver::getArtworkUrl()
- Prevents premature URL expiration during order submission

Issue lunarphp#2: Internal Supplier Seeder Command
- Created lunar:seed-internal-supplier artisan command
- Registered command in LunarServiceProvider
- Makes InternalSupplierSeeder easily runnable without modifying DatabaseSeeder

Issue lunarphp#3: Supplier Product Validation
- Added validation in HelloPrintDriver::submitOrder()
- Added validation in PrintComDriver::submitOrder()
- Returns OrderResponse::failed() if variant has no supplier product
- Prevents null reference exceptions during order submission

Issue lunarphp#4: PrintCom Sandbox Mode
- Added sandbox configuration to suppliers.php for PrintCom
- Added PRINTCOM_SANDBOX environment variable support
- Updated PrintComDriver::submitOrder() to include mode field (test/live)
- Matches HelloPrint driver pattern for consistency

Issue lunarphp#5: Meta Array Handling
- Standardized meta array handling in GetPrintComPrice pipeline
- Fixed potential array offset error when meta is null
- Properly initializes meta array before setting supplier_pricing

Issue lunarphp#6: Foreign Key Indexes
- Added explicit indexes for foreign key columns in supplier_orders table
- Added indexes for cancellation_requested_by, cancelled_by, approved_by
- Improves query performance for user-related lookups
- Added corresponding dropIndex calls in migration down() method

All changes are backward compatible and include proper test coverage.
Tests passing: 50 passed (175 assertions)

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants