Use max to prevent negative sub totals#2351
Merged
glennjacobs merged 8 commits into1.xfrom Dec 8, 2025
Merged
Conversation
…lunar into fix-discount-negative-subtotal
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
glennjacobs
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents reward lines from producing a negative discounted subtotal. Currently, if a BuyXGetY discount grants multiple free items but the cart contains fewer qualifying products, the discount calculation can push the subtotal below zero.
By wrapping the final discounted amount in max(0, ...), we ensure the subtotal never becomes negative. If the discount exceeds the cart line value, the subtotal is simply set to 0.00 until the customer adds enough qualifying items.