Add meta to product options and values#2346
Merged
glennjacobs merged 1 commit into1.xfrom Dec 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a meta field to both ProductOption and ProductOptionValue models to enable custom metadata storage (e.g., hex color values). Additionally, it updates the model annotations for accuracy and changes the cast type for ProductOptionValue's name field from AsCollection to AsArrayObject.
Key Changes:
- Added nullable
metaJSON fields toproduct_optionsandproduct_option_valuestables - Changed
ProductOptionValue::$namecast fromAsCollectiontoAsArrayObject - Updated PHPDoc annotations to reflect actual cast types
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/core/database/migrations/2025_11_12_005200_add_meta_to_product_options.php |
Migration adding meta JSONB columns to both tables |
packages/core/src/Models/ProductOption.php |
Added meta cast and updated annotations to use AsArrayObject |
packages/core/src/Models/ProductOptionValue.php |
Changed name cast to AsArrayObject, added meta cast, and updated annotations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wychoong
reviewed
Nov 12, 2025
wychoong
reviewed
Nov 12, 2025
wychoong
reviewed
Nov 12, 2025
alecritson
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds meta to Product Options & Product Option Values to support customisation, e.g. assigning hex colours.
It also updates the model annotations and corrects the
namecast on ProductOptionValue (this might be considered a breaking change...)TODO