Fix PostgreSQL driver check consistency in database indexes migration#2322
Closed
Copilot wants to merge 2 commits intoadd_missing_database_indexesfrom
Closed
Fix PostgreSQL driver check consistency in database indexes migration#2322Copilot wants to merge 2 commits intoadd_missing_database_indexesfrom
Copilot wants to merge 2 commits intoadd_missing_database_indexesfrom
Conversation
Co-authored-by: glennjacobs <[email protected]>
Copilot
AI
changed the title
[WIP] Add additional database indexes for query speed
Fix PostgreSQL driver check consistency in database indexes migration
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed inconsistent driver checks in the database indexes migration that could cause rollback failures on MySQL/SQLite databases.
Changes Made
morphs('channelable')already provides optimal composite indexing forchannelable_type+channelable_idqueriesThe migration now safely handles rollbacks across all database drivers by checking
DB::getDriverName() !== 'pgsql'in both directions.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.