Add translation support for EditShippingZone navigation label#2317
Merged
glennjacobs merged 5 commits intolunarphp:1.xfrom Nov 11, 2025
Merged
Add translation support for EditShippingZone navigation label#2317glennjacobs merged 5 commits intolunarphp:1.xfrom
glennjacobs merged 5 commits intolunarphp:1.xfrom
Conversation
Collaborator
|
Thanks, when adding translations we need to ensure we add the English version at a minimum, if you're able to provide the other translations (even via a service like Google Translate) it would help as well. :) |
…sh base translation
Contributor
Author
|
Of course! I already did it! Thanks for the heads-up. |
Contributor
|
Thanks @VincentTeresa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing getNavigationLabel() method to EditShippingZone to maintain consistency with other pages in the module (ManageShippingRates and ManageShippingExclusions). Fixes issue #2316