Fix: Prevents fatal errors for custom Purchasable models#2306
Merged
glennjacobs merged 6 commits intolunarphp:1.xfrom Nov 11, 2025
Merged
Fix: Prevents fatal errors for custom Purchasable models#2306glennjacobs merged 6 commits intolunarphp:1.xfrom
glennjacobs merged 6 commits intolunarphp:1.xfrom
Conversation
Contributor
|
@ablunier it looks like we have failing tests. Are you able to take a look? Thanks. |
Contributor
Author
|
Tests are now green @glennjacobs |
glennjacobs
approved these changes
Nov 11, 2025
Contributor
|
Thanks @ablunier |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves support for custom models that implement the Purchasable interface but are not standard ProductVariants.
Currently, using a custom purchasable can lead to two exceptions:
This PR resolves these issues with minimal impact:
This makes the Purchasable interface more robust and truly extensible as intended. Any feedback is welcome.