Skip to content

Add missing translation files#2304

Merged
glennjacobs merged 2 commits intolunarphp:1.xfrom
jonagoldman:1.x
Nov 11, 2025
Merged

Add missing translation files#2304
glennjacobs merged 2 commits intolunarphp:1.xfrom
jonagoldman:1.x

Conversation

@jonagoldman
Copy link
Contributor

@jonagoldman jonagoldman commented Sep 30, 2025 •
edited by coderabbitai bot
Loading

Add missing translation files related to taxes.

Summary by CodeRabbit

  • New Features
    • Added Tax resource translations for German, Spanish, French, Dutch, Polish, and Vietnamese (singular and plural labels).
    • Added German translations for the Tax Rate resource, including table columns (Name, Tax Zone, Priority) and form fields (Name, Priority, Tax Zone).
    • Improves multilingual support across the admin interface for tax-related sections.

@vercel
Copy link

vercel bot commented Sep 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lunar-docs Ready Ready Preview Comment Sep 30, 2025 9:32pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 30, 2025 •
edited
Loading

Walkthrough

Adds new localization files for tax labels in multiple languages and a German tax rate translation. All files return static PHP arrays with labels and, for tax rate, table/form field names. No logic changes.

Changes

Cohort / File(s) Summary of Changes
Tax label locales
packages/admin/resources/lang/.../tax.php (de, es, fr, nl, pl, vi)		 Added locale files returning arrays with 'label' and 'plural_label' for Tax.
Tax rate (de)
packages/admin/resources/lang/de/taxrate.php		 Added German translations for tax rate: 'label', 'plural_label', and table/form field names.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “feat: add missing translation files” accurately summarizes the primary change in the pull request, which is the addition of several new localization files for tax-related resources. It is concise, follows the conventional “feat:” prefix, and clearly communicates the intent without extraneous detail. A reviewer scanning the commit history can immediately understand that the PR introduces missing translation files. There is no unrelated or vague wording present.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ed29627 and 52d3b3e.

📒 Files selected for processing (7)
  • packages/admin/resources/lang/de/tax.php (1 hunks)
  • packages/admin/resources/lang/de/taxrate.php (1 hunks)
  • packages/admin/resources/lang/es/tax.php (1 hunks)
  • packages/admin/resources/lang/fr/tax.php (1 hunks)
  • packages/admin/resources/lang/nl/tax.php (1 hunks)
  • packages/admin/resources/lang/pl/tax.php (1 hunks)
  • packages/admin/resources/lang/vi/tax.php (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: search - PHP 8.4 - L12.* ↑ E
  • GitHub Check: core - PHP 8.4 - L12.* ↑ E
  • GitHub Check: core - PHP 8.4 - L12.* ↑
  • GitHub Check: core - PHP 8.4 - L11.* ↑
  • GitHub Check: search - PHP 8.4 - L12.* ↑
  • GitHub Check: search - PHP 8.3 - L12.* ↑
  • GitHub Check: admin - PHP 8.4 - L11.* ↑
  • GitHub Check: admin - PHP 8.4 - L11.* ↑ E
  • GitHub Check: core - PHP 8.4 - L11.* ↑ E
  • GitHub Check: stripe - PHP 8.3 - L12.* ↑
  • GitHub Check: admin - PHP 8.3 - L12.* ↑
  • GitHub Check: core - PHP 8.3 - L12.* ↑ E
  • GitHub Check: stripe - PHP 8.3 - L11.* ↑
  • GitHub Check: admin - PHP 8.3 - L12.* ↑ E
  • GitHub Check: core - PHP 8.3 - L12.* ↑
  • GitHub Check: shipping - PHP 8.3 - L11.* ↑ E
  • GitHub Check: admin - PHP 8.3 - L11.* ↑
  • GitHub Check: admin - PHP 8.3 - L11.* ↑ E
  • GitHub Check: core - PHP 8.3 - L11.* ↑ E
  • GitHub Check: core - PHP 8.3 - L11.* ↑
🔇 Additional comments (2)
packages/admin/resources/lang/de/tax.php (1)

1-9: LGTM! German tax translations are correct.

The translation file follows the standard Laravel localization format with proper PHP syntax. The German translations "Steuer" (singular) and "Steuern" (plural) are accurate.

packages/admin/resources/lang/de/taxrate.php (1)

1-33: LGTM! German tax rate translations are correct and well-structured.

The translation file properly defines labels for the tax rate resource including table columns and form fields. All German translations are accurate:

  • "Steuersatz" / "Steuersätze" for tax rate (singular/plural)
  • "Steuerzone" for tax zone
  • "Priorität" for priority

The structure correctly differentiates between tax_zone (table display) and tax_zone_id (form field).

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@glennjacobs glennjacobs added the i18n Language file contributions label Nov 10, 2025
@glennjacobs glennjacobs changed the title feat: add missing translation files Add missing translation files Nov 10, 2025
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Nov 10, 2025
@glennjacobs glennjacobs merged commit 43a7371 into lunarphp:1.x Nov 11, 2025
44 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Nov 11, 2025
@glennjacobs
Copy link
Contributor

glennjacobs commented Nov 11, 2025

Thanks @jonagoldman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glennjacobs glennjacobs glennjacobs approved these changes

Assignees

No one assigned

Labels

i18n Language file contributions

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonagoldman @glennjacobs