Fix: Allow the discount to be applied if no condition coupon exists regardless of the coupon code on the cart#2300
Merged
glennjacobs merged 3 commits intolunarphp:1.xfrom Nov 11, 2025
Conversation
…less of cart coupon Allow the discounts to be applied if no condition coupon exists regardless of cart coupon. This way discounts that doesn't have a coupon requirement can be added and not be removed because of another coupon discount that is applied.
…with-no-coupon-codes
Contributor
|
@ryanmitchell do you see any issues here? |
Contributor
|
Nope, seems ok to me. |
glennjacobs
approved these changes
Nov 11, 2025
Contributor
|
Thanks @xahmedtaha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the discounts to be applied if no condition coupon exists regardless of cart coupon. This way discounts that doesn't have a coupon requirement can be added and not be removed because of another coupon discount that is applied.
Current behaviour:
if a discount that has a coupon requirement is applied. and other discounts that doesn't have a coupon requirements are applied as well. the coupon code discount causes the other discounts not to apply to the cart at all because of a wrong $validCoupon comparison logic.
Expected behaviour:
discounts should be applied if there is no coupon code requirement regardless of the coupon code set on the cart. this way coupon discounts doesn't simply override all other discounts.