Skip to content

Add clarity for opt-out telemetry during upgrade#2299

Merged
glennjacobs merged 1 commit intolunarphp:1.xfrom
wychoong:patch-2
Sep 25, 2025
Merged

Add clarity for opt-out telemetry during upgrade#2299
glennjacobs merged 1 commit intolunarphp:1.xfrom
wychoong:patch-2

Conversation

@wychoong
Copy link
Contributor

@wychoong wychoong commented Sep 25, 2025

just to add some clarity to put the telemetry opt-out in boot()

Summary by CodeRabbit

  • Documentation
    • Updated the upgrading guide to clarify opt-out steps, directing users to perform them in the service provider’s boot method rather than the general provider.
    • No changes to application behavior, APIs, or configuration are introduced by this update.
    • Aims to improve clarity for users following upgrade instructions.

@vercel
Copy link

vercel bot commented Sep 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lunar-docs Ready Ready Preview Comment Sep 25, 2025 8:57am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Documentation text in docs/core/upgrading.md was updated to specify opting out via the service provider’s boot method instead of the general service provider. No code or API changes.

Changes

Cohort / File(s) Summary
Docs update
docs/core/upgrading.md
Clarified instructions to opt out via the service provider’s boot method; text-only change, no functional impact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b64b59c and 9e7b10e.

📒 Files selected for processing (1)
  • docs/core/upgrading.md (1 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@glennjacobs glennjacobs merged commit d2e6a30 into lunarphp:1.x Sep 25, 2025
47 of 48 checks passed
@wychoong wychoong deleted the patch-2 branch September 25, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants