tests/core/Unit/Pipelines/Order/Creation/CleanUpOrderLinesTest.php (3)

95-102: Scope DB assertions to the current order to avoid false positives.

Include order_id in the where clauses for precision.

-    assertDatabaseHas((new OrderLine)->getTable(), [
-        'purchasable_id' => $purchasable->id,
-    ]);
+    assertDatabaseHas((new OrderLine)->getTable(), [
+        'order_id' => $order->id,
+        'purchasable_id' => $purchasable->id,
+    ]);

-    assertDatabaseMissing((new OrderLine)->getTable(), [
-        'purchasable_id' => $purchasableB->id,
-    ]);
+    assertDatabaseMissing((new OrderLine)->getTable(), [
+        'order_id' => $order->id,
+        'purchasable_id' => $purchasableB->id,
+    ]);

---

106-106: Clarify test title.

Make the intent explicit: differing quantity or meta.

- test('will remove lines with same purchasable ids when different', function () {
+ test('removes lines with same purchasable_id when quantity or meta differ', function () {

---

204-214: Prefer JSON path assertions over raw JSON string equality.

Asserting meta via a JSON path is more robust across drivers than string-matching json_encode output.

Option A (simple): use JSON path columns if supported in your test DB driver.

-    assertDatabaseHas((new OrderLine)->getTable(), [
-        'purchasable_id' => $purchasableB->id,
-        'quantity' => 5,
-        'meta' => json_encode(['foo' => 'bar']),
-    ]);
+    assertDatabaseHas((new OrderLine)->getTable(), [
+        'purchasable_id' => $purchasableB->id,
+        'quantity' => 5,
+        'meta->foo' => 'bar',
+    ]);

-    assertDatabaseMissing((new OrderLine)->getTable(), [
-        'purchasable_id' => $purchasableB->id,
-        'quantity' => 15,
-        'meta' => json_encode(['bar' => 'baz']),
-    ]);
+    assertDatabaseMissing((new OrderLine)->getTable(), [
+        'purchasable_id' => $purchasableB->id,
+        'quantity' => 15,
+        'meta->bar' => 'baz',
+    ]);

If SQLite JSON1 or your driver doesn’t support meta->key in where, keep your current approach or switch to a query using whereJsonContains for those checks.

packages/core/src/Pipelines/Order/Creation/CleanUpOrderLines.php (3)

20-23: Build a set for O(1) membership checks.

Converting the signatures array into a hash set avoids repeated linear in_array scans.

-        // Build a set of "signatures" that uniquely identify each cart line
-        $cartSignatures = $cart->lines->map(function ($line) {
-            return $this->signature($line->purchasable_id, (array) $line->meta, $line->quantity);
-        })->toArray();
+        // Build a set of "signatures" that uniquely identify each cart line
+        $cartSignatures = $cart->lines->map(function ($line) {
+            return $this->signature($line->purchasable_id, (array) $line->meta, $line->quantity);
+        })->toArray();
+        $cartSignatureSet = array_flip($cartSignatures);

---

25-35: Use the set for membership checks (avoid in_array).

Switch to isset on the flipped set for faster lookups.

-        $order->productLines->each(function ($orderLine) use ($cartSignatures) {
+        $order->productLines->each(function ($orderLine) use ($cartSignatureSet) {
             $sig = $this->signature(
                 $orderLine->purchasable_id,
                 (array) $orderLine->meta,
                 $orderLine->quantity,
             );
 
-            if (! in_array($sig, $cartSignatures, true)) {
+            if (! isset($cartSignatureSet[$sig])) {
                 $orderLine->delete();
             }
         });

---

40-47: Normalize meta recursively for stable signatures.

Sorting only top-level keys can produce mismatches if meta has nested structures. Normalize recursively before encoding.

-    private function signature(string $purchasableId, array $meta, int $qty): string
+    private function signature(string $purchasableId, array $meta, int $qty): string
     {
-        return md5(json_encode([
-            'id' => $purchasableId,
-            'meta' => collect($meta)->sortKeys()->toArray(),
-            'qty' => $qty,
-        ]));
+        return md5(json_encode([
+            'id' => (string) $purchasableId,
+            'meta' => $this->normalizeMeta($meta),
+            'qty' => (int) $qty,
+        ], JSON_UNESCAPED_SLASHES));
     }

Add this helper within the class:

private function normalizeMeta(mixed $value): mixed
{
    if (is_array($value)) {
        // Normalize associative arrays by key; preserve order for indexed arrays
        $isAssoc = array_keys($value) !== range(0, count($value) - 1);
        if ($isAssoc) {
            ksort($value);
        }
        foreach ($value as $k => $v) {
            $value[$k] = $this->normalizeMeta($v);
        }
        return $value;
    }
    if ($value instanceof \ArrayObject) {
        return $this->normalizeMeta((array) $value);
    }
    return $value;
}

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

tests/core/Unit/Pipelines/Order/Creation/CleanUpOrderLinesTest.php (1)

207-212: Prefer JSON path assertions over raw JSON encoding for meta

Using meta->key paths is more driver-agnostic (MySQL/Postgres/SQLite) and resilient to JSON normalization differences than comparing serialized JSON strings.

Apply this diff:

-    assertDatabaseHas((new OrderLine)->getTable(), [
-        'order_id' => $order->id,
-        'purchasable_id' => $purchasableB->id,
-        'quantity' => 5,
-        'meta' => json_encode(['foo' => 'bar']),
-    ]);
+    assertDatabaseHas((new OrderLine)->getTable(), [
+        'order_id' => $order->id,
+        'purchasable_id' => $purchasableB->id,
+        'quantity' => 5,
+        'meta->foo' => 'bar',
+    ]);

-    assertDatabaseMissing((new OrderLine)->getTable(), [
-        'order_id' => $order->id,
-        'purchasable_id' => $purchasableB->id,
-        'quantity' => 15,
-        'meta' => json_encode(['bar' => 'baz']),
-    ]);
+    assertDatabaseMissing((new OrderLine)->getTable(), [
+        'order_id' => $order->id,
+        'purchasable_id' => $purchasableB->id,
+        'quantity' => 15,
+        'meta->bar' => 'baz',
+    ]);

Also applies to: 214-219

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro