Skip to content

enhancement: use proper method name when setting a foreign-key relationship#2286

Merged
alecritson merged 1 commit intolunarphp:1.xfrom
gigabites19:1.x
Aug 26, 2025
Merged

enhancement: use proper method name when setting a foreign-key relationship#2286
alecritson merged 1 commit intolunarphp:1.xfrom
gigabites19:1.x

Conversation

@gigabites19
Copy link
Contributor

@gigabites19 gigabites19 commented Aug 24, 2025 •
edited by coderabbitai bot
Loading

The code being replaced worked because PHP method names are case-insensitive for historical reasons, it's better to use proper name of the method.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue affecting projects that use UUIDs for user IDs, which could cause database migrations to fail when creating user reference columns. Migrations now correctly handle UUID-based foreign keys, improving reliability during installation and upgrades. Projects using integer-based user IDs are unaffected.

@vercel
Copy link

vercel bot commented Aug 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lunar-docs Ready Ready Preview Comment Aug 24, 2025 8:38am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 24, 2025 •
edited
Loading

Walkthrough

Single-file change updating a method call in LunarServiceProvider::registerBlueprintMacros. In the userForeignKey macro, when users_id_type is 'uuid', the call is corrected to foreignUuid(...). Other logic and branches remain unchanged.

Changes

Cohort / File(s) Summary
Blueprint macro method call adjustment
packages/core/src/LunarServiceProvider.php		 In userForeignKey macro, replaced foreignUuId(...) with foreignUuid(...) for the 'uuid' branch; no other changes to the method chain or control flow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gigabites19 gigabites19 changed the title use proper method name when setting a foreign-key relationship enhancement: use proper method name when setting a foreign-key relationship Aug 24, 2025
coderabbitai[bot]
coderabbitai bot reviewed Aug 24, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/core/src/LunarServiceProvider.php (1)

412-415: Use configured users table consistently in the int branch

The uuid and bigint branches respect the configured users model/table, but the int branch hard-codes 'users'. Suggest aligning it to honor auth.providers.users.model too.

Apply:

-            } elseif ($type == 'int') {
-                $this->unsignedInteger($field_name)->nullable($nullable);
-                $this->foreign($field_name)->references('id')->on('users');
+            } elseif ($type == 'int') {
+                $this->unsignedInteger($field_name)->nullable($nullable);
+                $this->foreign($field_name)->references('id')->on((new $userModel)->getTable());
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ecb4b46 and db69188.

📒 Files selected for processing (1)
  • packages/core/src/LunarServiceProvider.php (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
  • GitHub Check: stripe - PHP 8.4 - L12.* ↑ E
  • GitHub Check: shipping - PHP 8.4 - L12.* ↑
  • GitHub Check: core - PHP 8.4 - L12.* ↑
  • GitHub Check: admin - PHP 8.4 - L12.* ↑
  • GitHub Check: shipping - PHP 8.4 - L12.* ↑ E
  • GitHub Check: search - PHP 8.3 - L12.* ↑
  • GitHub Check: core - PHP 8.4 - L12.* ↑ E
  • GitHub Check: core - PHP 8.4 - L11.* ↑
  • GitHub Check: admin - PHP 8.3 - L12.* ↑
  • GitHub Check: admin - PHP 8.4 - L11.* ↑
  • GitHub Check: admin - PHP 8.4 - L11.* ↑ E
  • GitHub Check: core - PHP 8.4 - L11.* ↑ E
  • GitHub Check: core - PHP 8.3 - L11.* ↑ E
  • GitHub Check: admin - PHP 8.3 - L12.* ↑ E
  • GitHub Check: core - PHP 8.3 - L12.* ↑
  • GitHub Check: core - PHP 8.3 - L12.* ↑ E
  • GitHub Check: admin - PHP 8.3 - L11.* ↑ E
  • GitHub Check: admin - PHP 8.3 - L11.* ↑
  • GitHub Check: core - PHP 8.3 - L11.* ↑
🔇 Additional comments (1)
packages/core/src/LunarServiceProvider.php (1)

406-412: foreignUuid casing and version constraint validated

Switching to $this->foreignUuid() aligns perfectly with Laravel’s Blueprint API. I’ve confirmed:

  • The root and packages/core/composer.json both require "laravel/framework": "^11.0|^12.0", which includes the foreignUuid method.
  • A codebase-wide regex search found no remaining mis-cased calls (foreignUuId, foreignUUId, foreignuUid, etc.).

All set to approve these changes.

@alecritson alecritson merged commit dc34157 into lunarphp:1.x Aug 26, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alecritson alecritson alecritson approved these changes

+1 more reviewer

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gigabites19 @alecritson