Skip to content

feat: add translations for name label in create product option value#2282

Merged
glennjacobs merged 1 commit intolunarphp:1.xfrom
SecurID:fix/product-option-field
Nov 11, 2025
Merged

feat: add translations for name label in create product option value#2282
glennjacobs merged 1 commit intolunarphp:1.xfrom
SecurID:fix/product-option-field

Conversation

@SecurID
Copy link
Contributor

@SecurID SecurID commented Aug 19, 2025 •
edited by coderabbitai bot
Loading

Added these translations while I investigated this issue: #2263

Summary by CodeRabbit

  • New Features
    • Added “Values” section translations across multiple languages (de, en, es, fr, nl, pl, vi).
    • Introduced form label for the “Name” field in the Values section for all supported languages.
    • Enhanced German locale with a section title (“Werte”) and table column labels (“Name”, “Position”) for the Values list.
    • Improves multilingual consistency and clarity in the admin interface.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 19, 2025 •
edited
Loading

Walkthrough

Adds translation entries for a “values” section across language files. German introduces a new group with title, form name label, and table columns. English, Spanish, French, Dutch, Polish, and Vietnamese add values.form.name.label without altering other keys.

Changes

Cohort / File(s) Summary of changes
Add new 'values' group (de)
packages/admin/resources/lang/de/relationmanagers.php		 Adds top-level values group with: title 'Werte'; form.name.label 'Name'; table.name.label 'Name'; table.position.label 'Position'.
Add form name label (en, es, fr, nl, pl, vi)
packages/admin/resources/lang/en/relationmanagers.php, .../es/relationmanagers.php, .../fr/relationmanagers.php, .../nl/relationmanagers.php, .../pl/relationmanagers.php, .../vi/relationmanagers.php		 Adds values.form.name.label with language-specific label ('Name', 'Nombre', 'Nom', 'Naam', 'Nazwa', 'Tên'). No other keys modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ecb4b46 and d37c520.

📒 Files selected for processing (7)
  • packages/admin/resources/lang/de/relationmanagers.php (1 hunks)
  • packages/admin/resources/lang/en/relationmanagers.php (1 hunks)
  • packages/admin/resources/lang/es/relationmanagers.php (1 hunks)
  • packages/admin/resources/lang/fr/relationmanagers.php (1 hunks)
  • packages/admin/resources/lang/nl/relationmanagers.php (1 hunks)
  • packages/admin/resources/lang/pl/relationmanagers.php (1 hunks)
  • packages/admin/resources/lang/vi/relationmanagers.php (1 hunks)
🔇 Additional comments (7)
packages/admin/resources/lang/vi/relationmanagers.php (1)

266-270: LGTM: Added values.form.name.label is correct and consistent.

"Tên" is accurate for the Name label, and the nesting matches existing structure under values.

packages/admin/resources/lang/en/relationmanagers.php (1)

275-279: ✅ Translation Key Consistency Verified Across All Locales

The values.form.name.label entry has been confirmed in every relationmanagers.php under packages/admin/resources/lang/*. This addition matches the established shape used elsewhere—no further changes needed.

packages/admin/resources/lang/es/relationmanagers.php (1)

266-270: LGTM: Se añadió values.form.name.label correctamente.

"Nombre" es correcto y la estructura coincide con el patrón existente.

packages/admin/resources/lang/nl/relationmanagers.php (1)

266-270: LGTM: values.form.name.label toegevoegd met juiste structuur.

"Naam" is correct en consistent met bestaande keys.

packages/admin/resources/lang/fr/relationmanagers.php (1)

266-270: LGTM : Ajout de values.form.name.label correct et cohérent.

"Nom" est approprié et la structure respecte le schéma existant.

packages/admin/resources/lang/de/relationmanagers.php (1)

215-230: Approve German translation for Product Option values form label
The packages/admin/resources/lang/de/relationmanagers.php file correctly defines the values group with the nested form.name.label key (“Name”), matching the structure used in other locales. Approving these changes.

packages/admin/resources/lang/pl/relationmanagers.php (1)

229-233: Polish “values.form.name.label” added and consistent with existing group.

“Nazwa” is correct, placement under values.form mirrors other locales, and it aligns with the create-flow needs.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel
Copy link

vercel bot commented Aug 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lunar-docs Ready Ready Preview Comment Aug 19, 2025 3:41pm

@glennjacobs glennjacobs added the i18n Language file contributions label Nov 10, 2025
@glennjacobs glennjacobs merged commit 4aaac8f into lunarphp:1.x Nov 11, 2025
4 checks passed
@glennjacobs
Copy link
Contributor

glennjacobs commented Nov 11, 2025

Thanks @SecurID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glennjacobs glennjacobs glennjacobs approved these changes

Assignees

No one assigned

Labels

i18n Language file contributions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SecurID @glennjacobs