Skip to content

Fix vendor publish command for pdfs#2281

Merged
glennjacobs merged 5 commits intolunarphp:1.xfrom
SecurID:1.x
Nov 11, 2025
Merged

Fix vendor publish command for pdfs#2281
glennjacobs merged 5 commits intolunarphp:1.xfrom
SecurID:1.x

Conversation

@SecurID
Copy link
Contributor

@SecurID SecurID commented Aug 19, 2025 •
edited by glennjacobs
Loading

This will fix issue #2265

I am not sure about the naming of the publish tag.
I think lunar.pdf fits better as this will only target all pdfs currently (and in the future) in lunar.

If accepted we need to edit the docs aswell.

Docs: lunarphp/docs#3

@vercel
Copy link

vercel bot commented Aug 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lunar-docs Ready Ready Preview Comment Aug 19, 2025 1:37pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 19, 2025 •
edited
Loading

Walkthrough

Adds a new asset publish mapping for PDF view templates in LunarPanelProvider and updates documentation examples to use the new publish tag lunar.pdf. No other runtime behavior or public API changes.

Changes

Cohort / File(s) Summary
Asset publishing update
packages/admin/src/LunarPanelProvider.php		 Added a publishes() call mapping __DIR__.'/../resources/views/pdf' to resource_path('views/vendor/lunarpanel/pdf') with tag lunar.pdf.
Documentation updates
docs/core/reference/orders.md		 Replaced lunar.hub.views publish tag with lunar.pdf in two code examples and corresponding command snippets.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 88b9412 and 1d5bd7e.

📒 Files selected for processing (1)
  • packages/admin/src/LunarPanelProvider.php (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/admin/src/LunarPanelProvider.php
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SecurID
Copy link
Contributor Author

SecurID commented Aug 19, 2025

Just saw that the docs are in the same repo so I updated them aswell.

coderabbitai[bot]
coderabbitai bot reviewed Aug 19, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ecb4b46 and fb2287b.

📒 Files selected for processing (1)
  • packages/admin/src/LunarPanelProvider.php (1 hunks)

@SecurID @coderabbitai
fix: override correct namespace
1d5bd7e 
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@glennjacobs glennjacobs added the documentation Improvements or additions to documentation label Nov 11, 2025
@glennjacobs glennjacobs changed the title fix: add vendor publish command for pdfs Fix vendor publish command for pdfs Nov 11, 2025
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Nov 11, 2025
@glennjacobs glennjacobs mentioned this pull request Nov 11, 2025
Merged
@glennjacobs glennjacobs merged commit cd8328b into lunarphp:1.x Nov 11, 2025
44 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SecurID @glennjacobs