Skip to content

remove shipping methods table's update from migration#2278

Merged
glennjacobs merged 1 commit intolunarphp:1.xfrom
gigabites19:remove-shipping-methods
Aug 17, 2025
Merged

remove shipping methods table's update from migration#2278
glennjacobs merged 1 commit intolunarphp:1.xfrom
gigabites19:remove-shipping-methods

Conversation

@gigabites19
Copy link
Contributor

@gigabites19 gigabites19 commented Aug 17, 2025 •
edited by coderabbitai bot
Loading

This migration is aimed at PostgreSQL databases. It targets columns that were previously of type json and changes them to jsonb. The line removed in the PR causes a problem because the table mentioned does not exist in Lunar. This causes new installations that use PostgreSQL to fail.

Relevant issue:

Summary by CodeRabbit

  • Chores
    • Updated a database migration to exclude a shipping-related field from JSON/JSONB conversions.
    • Streamlines the migration process and reduces unnecessary data alterations during upgrades or rollbacks.
    • Improves operational stability for deployments involving historical data.
    • No changes to user experience or visible functionality; the application behaves as before.

@vercel
Copy link

vercel bot commented Aug 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lunar-docs Ready Ready Preview Comment Aug 17, 2025 8:27am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 17, 2025 •
edited
Loading

Walkthrough

The migration packages/core/database/migrations/2025_08_14_164000_switch_to_jsonb.php was updated to exclude shipping_methods.data from the set of columns converted to jsonb in up() and reverted to json in down(); all other logic remains unchanged.

Changes

Cohort / File(s) Summary
Migration JSONB updates
packages/core/database/migrations/2025_08_14_164000_switch_to_jsonb.php		 Removed shipping_methods.data from columns processed for JSON⇄JSONB conversion in up()/down(); no other alterations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • Move to JSONB #2270 — Earlier change to the same migration adjusting handling of shipping_methods.data; this PR reverses that part by excluding the column.

Suggested reviewers

  • alecritson

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7def927 and 6a0c1bd.

📒 Files selected for processing (1)
  • packages/core/database/migrations/2025_08_14_164000_switch_to_jsonb.php (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/core/database/migrations/2025_08_14_164000_switch_to_jsonb.php
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@glennjacobs glennjacobs merged commit ece86f7 into lunarphp:1.x Aug 17, 2025
48 checks passed
@alecritson alecritson mentioned this pull request Aug 18, 2025
Merged
glennjacobs added a commit that referenced this pull request Nov 11, 2025
@alecritson @glennjacobs @actions-user
Ensure shipping table json fields are set to jsonb (#2279)
8972ebe 
#2278 Removed the `jsonb` changes from shipping tables but didn't
reapply them via the shipping addon. This PR mimics the core migration
but within the shipping addon.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- Chores
- Migrated shipping method data storage to a more efficient format on
PostgreSQL, improving query performance and scalability.
- Backward-compatible and reversible; no action required for
non-PostgreSQL setups.
- Ensures more consistent behavior and prepares the system for future
enhancements.
- Seamless upgrade path with automatic migration during update; no
user-facing changes expected.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Glenn Jacobs <[email protected]>
Co-authored-by: Author <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glennjacobs glennjacobs glennjacobs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gigabites19 @glennjacobs