Skip to content

v1.0.0 prep#2273

Merged
glennjacobs merged 3 commits into1.xfrom
1.0.0-prep
Aug 15, 2025
Merged

v1.0.0 prep#2273
glennjacobs merged 3 commits into1.xfrom
1.0.0-prep

Conversation

@glennjacobs
Copy link
Contributor

@glennjacobs glennjacobs commented Aug 15, 2025

Updates documentation for v1.0.0 release

Summary by CodeRabbit

  • Documentation
    • Removed beta cautions and production-readiness warnings across docs; content reflects a 1.x/stable focus.
    • Simplified installation guidance and reorganized advanced options (telemetry moved under Advanced).
    • Revamped upgrade guide into versioned 1.x roadmap with alpha/beta/stable notes and migration guidance.
    • Updated admin references to Filament and minor formatting improvements.
    • Removed “Initial Set‑Up” and “Release Schedule” pages; adjusted navigation.
    • Trimmed security guidance and added support note: no full codebase reviews.

@vercel
Copy link

vercel bot commented Aug 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lunar-docs Ready Preview Comment Aug 15, 2025 9:47am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 15, 2025

Walkthrough

This PR updates documentation across the repo: removes beta/requirements notices, restructures installation and overview content, deletes “Initial Set-Up” and “Release Schedule” pages and sidebar links, overhauls the upgrading guide for 1.x (docs-only), adjusts security and contributing docs, adds a support exclusion, and reflows README text. No code changes.

Changes

Cohort / File(s) Summary
Root README files
README.md, packages/core/README.md
Removed Requirements and beta/production-readiness blocks; minor line-wrap/reflow edits.
VitePress nav config
docs/.vitepress/config.js
Removed “Initial Set-Up” (/core/set-up) and “Release Schedule” (/core/release-schedule) entries from Core Getting Started sidebar.
Admin & Core overview/installation
docs/admin/overview.md, docs/core/installation.md, docs/core/overview.md
Deleted beta warning blocks; updated wording (admin → Filament/ admin panel); changed composer constraint to ^1.0; removed minimum-stability tip; moved Telemetry under “Advanced Installation Options”; minor formatting.
Deleted core pages
docs/core/set-up.md, docs/core/release-schedule.md
Removed pages: Initial Set-Up and Release Schedule (entire content deleted).
Upgrading guide (major doc rewrite)
docs/core/upgrading.md
Replaced long-form changelog with versioned 1.x upgrade narrative: added 1.0.0 (stable) and pre-release alpha/beta notes; documents many documented public API/model/contract signature and migration notes (docs-only).
Contributing, security, support
docs/core/contributing.md, docs/core/securing-your-site.md, docs/support.md
Pruned and reformatted contributing guidance (removed branching/code-style sections, added automated tests note); removed Ploi guidance; normalized Algolia link; added Premium Support exclusion for full codebase reviews.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 1.0.0-prep

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@glennjacobs glennjacobs marked this pull request as ready for review August 15, 2025 09:41
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🔭 Outside diff range comments (1)
docs/core/installation.md (1)

51-59: Code block likely broken: missing closing braces and fence

The AppServiceProvider example doesn’t close the method/class, and the code fence appears unclosed. This will render incorrectly and could confuse readers.

Apply the following fix to close the method, the class, and the code fence:

 use Lunar\Admin\Support\Facades\LunarPanel;
 
 class AppServiceProvider extends ServiceProvider
 {
     public function register(): void
     {
         LunarPanel::register();
     }
-}
+}
+}
- 
+```
🧹 Nitpick comments (19)
docs/support.md (1)

43-43: Tighten phrasing for clarity and tone consistency

“snippets of code” is fine, but the latter clause reads more cleanly without a contraction and aligns with the surrounding formal tone.

Apply this diff:

- - 🚫 Full codebase reviews – We can review snippets of code, but not an entire application.
+ - 🚫 Full codebase reviews – We can review code snippets, but cannot review an entire application.
docs/admin/overview.md (2)

3-3: Consider linking to Filament v3 docs

Adding a link helps readers jump straight to the relevant framework.

-Lunar's admin panel is powered by **Filament v3**. It allows you to easily extend the admin panel to suit your project.
+Lunar's admin panel is powered by **[Filament v3](https://filamentphp.com/docs/3.x)**. It allows you to easily extend the admin panel to suit your project.

14-20: Verify the code sample has a closing class brace

The example appears to be missing the class’ closing brace. Adding it avoids copy/paste errors for readers.

 class AppServiceProvider extends ServiceProvider
 {
     public function register(): void
     {
         LunarPanel::register();
     }
+}
packages/core/README.md (1)

5-6: Fix possessive “its” and hyphenation; align style with the project

Small grammar/style pass to improve clarity and consistency (“its” vs “it’s”, “open‑source”, “e‑commerce”, and “feature‑rich”).

-Lunar is an open source E-commerce platform which embraces Laravel as it's foundation and uses it to build a highly 
-extensible, robust and feature rich application you can build any store on.
+Lunar is an open-source e-commerce platform that embraces Laravel as its foundation and uses it to build a highly
+extensible, robust, and feature-rich application you can build any store on.
docs/core/overview.md (3)

14-16: Use a colon and add commas for readability; optionally link to Filament

Minor punctuation improves readability. Adding a link is optional but helpful.

-Lunar is comprised of two packages; `lunarphp/core` which provides the e-commerce functionality and `lunarphp/lunar` 
-which provides an admin panel built on Filament.
+Lunar is comprised of two packages: `lunarphp/core`, which provides the e-commerce functionality, and `lunarphp/lunar`,
+which provides an admin panel built on [Filament](https://filamentphp.com/docs/3.x).

17-19: Clarify Livewire mention with a link

Since Filament uses Livewire, linking Livewire helps readers who aren’t familiar with it.

-:::info
-Although the admin panel uses Laravel Livewire, there is no requirement for your app to use Livewire itself.
-:::
+:::info
+Although the admin panel uses [Laravel Livewire](https://livewire.laravel.com/), there is no requirement for your app to use Livewire itself.
+:::

23-24: Tone: replace “awesome” with a more neutral alternative

Keeps the docs’ tone professional.

-Lunar as a company has grand plans to continue developing new functionality to help you build awesome e-commerce 
+Lunar as a company has grand plans to continue developing new functionality to help you build high-quality e-commerce
 websites. We want Lunar to be a true alternative to the likes of Magento, Shopify, WooCommerce, etc.
docs/core/installation.md (2)

79-81: Fix comma splices and tighten wording in Telemetry paragraph

Current sentence has two comma splices and reads a bit heavy. Recommend splitting into shorter sentences.

-Lunar will phone home to send anonymous usage insights, the data we capture does not identify your store in any way, it
-exists to help us gain an understanding of how Lunar is used. You can easily opt out of this by adding the following to
-your service provider's boot method:
+Lunar will phone home to send anonymous usage insights. The data we capture does not identify your store in any way.
+This exists to help us understand how Lunar is used. You can opt out by adding the following to
+your service provider's boot method:

89-94: Minor consistency nit: “User ID” type guidance

This guidance is helpful. Consider linking directly to the config file path in the Monorepo for quick reference if feasible (optional).

docs/core/contributing.md (6)

7-8: Reduce wordiness and improve phrasing

Tighten the sentence and avoid “make” + noun.

-You can contribute to the project in many different ways. Reporting bugs, fixing bugs, helping with the documentation, 
-making suggestions and submitting improvements to the software.
+You can contribute in many ways: reporting bugs, fixing bugs, helping with the documentation,
+suggesting enhancements, and submitting improvements to the software.

25-31: Pluralization and hyphenation fixes

  • “monorepo's” should be “monorepos” (plural, not possessive).
  • “set-up” (as a verb) should be “set up”.
-However, if you're not used to working with monorepo's and setting them up inside a test Laravel application, no problem!
+However, if you're not used to working with monorepos and setting them up inside a test Laravel application, no problem!
 
 ::: tip
-Here's a guide on how to set-up your development environment ready for contributing to Lunar.
+Here's a guide on how to set up your development environment, ready for contributing to Lunar.

51-57: Hyphenate “Open‑source” in compound adjective usage

-Open source code belongs to all of us, and it's all of our responsibility to push it forward.
+Open-source code belongs to all of us, and it's all of our responsibility to push it forward.

60-63: Tone and clarity: replace “awesome”, clarify expectation

-Before you start coding away on the next awesome feature, we highly recommend starting a 
+Before you start building the next feature, we highly recommend starting a
 [discussion](https://github.com/lunarphp/lunar/discussions) to check that your contribution will be welcomed. We would 
-hate for you to spend valuable time on something that won't be merged into Lunar.
+hate for you to spend valuable time on something that won't be merged.

73-81: Tighten PR checklist lead-in and modernize test phrasing

-A PR should be able to include the following:
+A PR should include the following:
@@
-- Automated tests with adequate code coverage
+- Automated tests with adequate coverage

84-85: Improve flow

-If you would like to contribute to the documentation you can do easily by following these instructions...
+If you’d like to contribute to the documentation, you can do so easily by following these instructions:
docs/core/upgrading.md (4)

282-284: Grammar: singular/plural agreement and article usage

-Collection Group now have unique index on the column `handle`.
-If you are creating Collection Group from the admin panel, there is no changes required.
+Collection groups now have a unique index on the `handle` column.
+If you are creating collection groups from the admin panel, there are no changes required.

362-364: Grammar: “upgrade” → “upgraded”

-This package has been upgrade to version 11, which introduces some breaking changes.
+This package has been upgraded to version 11, which introduces some breaking changes.

365-369: Typo and clarity in “Media Conversions”

Fixes “definitionss” and slightly tightens the wording.

-The `lunar.media.conversions` configuration has been removed, in favour of registering custom media definitionss instead.
-Media definition classes allow you to register media collections, conversions and much more. See [Media Collections](/core/reference/media.html#media-collections)
+The `lunar.media.conversions` configuration has been removed in favour of registering custom media definitions instead.
+Media definition classes allow you to register media collections, conversions, and more. See [Media Collections](/core/reference/media.html#media-collections)
 for further information.

371-377: Consistency: clarify renaming language

Optional, but you may want to explicitly say “rename references from ‘tiers’ to ‘priceBreaks’” for quicker scanning. If you prefer to keep the current style, ignore.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between be7f0c5 and cceeb2e.

📒 Files selected for processing (12)
  • README.md (0 hunks)
  • docs/.vitepress/config.js (0 hunks)
  • docs/admin/overview.md (1 hunks)
  • docs/core/contributing.md (5 hunks)
  • docs/core/installation.md (2 hunks)
  • docs/core/overview.md (1 hunks)
  • docs/core/release-schedule.md (0 hunks)
  • docs/core/securing-your-site.md (1 hunks)
  • docs/core/set-up.md (0 hunks)
  • docs/core/upgrading.md (2 hunks)
  • docs/support.md (1 hunks)
  • packages/core/README.md (1 hunks)
💤 Files with no reviewable changes (4)
  • docs/core/set-up.md
  • docs/.vitepress/config.js
  • README.md
  • docs/core/release-schedule.md
🧰 Additional context used
🪛 LanguageTool
docs/support.md

[grammar] ~43-~43: There might be a mistake here.
Context: ... you, but we won’t write custom code. - 🚫 Full codebase reviews – We can review ...

(QB_NEW_EN)


[grammar] ~43-~43: There might be a mistake here.
Context: ... write custom code. - 🚫 Full codebase reviews – We can review snippets of code, but not an ...

(QB_NEW_EN)

docs/core/installation.md

[grammar] ~79-~79: There might be a mistake here.
Context: ...s not identify your store in any way, it exists to help us gain an understanding ...

(QB_NEW_EN)


[grammar] ~80-~80: There might be a mistake here.
Context: ...t out of this by adding the following to your service provider's boot method: ``...

(QB_NEW_EN)

docs/core/overview.md

[style] ~21-~21: ‘future plans’ might be wordy. Consider a shorter alternative.
Context: ...e Livewire itself. ::: ## What are the future plans? Lunar as a company has grand plans to...

(EN_WORDINESS_PREMIUM_FUTURE_PLANS)


[style] ~23-~23: Consider using a more formal and expressive alternative to ‘awesome’.
Context: ...ing new functionality to help you build awesome e-commerce websites. We want Lunar to ...

(AWESOME)

docs/core/contributing.md

[style] ~7-~7: ‘many different ways’ might be wordy. Consider a shorter alternative.
Context: .... You can contribute to the project in many different ways. Reporting bugs, fixing bugs, helping w...

(EN_WORDINESS_PREMIUM_MANY_DIFFERENT_WAYS)


[style] ~7-~7: “Make” is an overused word. Consider a different verb to strengthen your wording.
Context: ... bugs, helping with the documentation, making suggestions and submitting improvements...

(MAKE_A_SUGGESTION)


[grammar] ~51-~51: There might be a mistake here.
Context: ... to get the attention it needs. :::info Be aware that creating an issue does not...

(QB_NEW_EN)


[uncategorized] ~54-~54: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...t to look into it as soon as possible. Open source code belongs to all of us, and it's all...

(EN_COMPOUND_ADJECTIVE_INTERNAL)


[style] ~60-~60: Consider using a more formal and expressive alternative to ‘awesome’.
Context: ...efore you start coding away on the next awesome feature, we highly recommend starting a...

(AWESOME)


[grammar] ~69-~69: There might be a mistake here.
Context: ...ture can be reviewed in a timely manner. If the pull request is missing informati...

(QB_NEW_EN)

docs/core/upgrading.md

[grammar] ~350-~350: There might be a mistake here.
Context: ...\Stripe; ``` ## 1.0.0-alpha :::warning If upgrading from 0.x please ensure yo...

(QB_NEW_EN)


[grammar] ~351-~351: There might be a mistake here.
Context: ... are on 0.8 before upgrading to 1.x. ::: ### High Impact #### Change to Sta...

(QB_NEW_EN)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: search - PHP 8.4 - L12.* ↑
  • GitHub Check: stripe - PHP 8.4 - L12.* ↑
  • GitHub Check: admin - PHP 8.4 - L12.* ↑
  • GitHub Check: stripe - PHP 8.4 - L12.* ↑ E
  • GitHub Check: core - PHP 8.4 - L12.* ↑ E
  • GitHub Check: shipping - PHP 8.4 - L12.* ↑
  • GitHub Check: core - PHP 8.4 - L11.* ↑ E
  • GitHub Check: admin - PHP 8.3 - L11.* ↑
  • GitHub Check: shipping - PHP 8.4 - L11.* ↑
  • GitHub Check: search - PHP 8.3 - L12.* ↑
  • GitHub Check: admin - PHP 8.4 - L11.* ↑ E
  • GitHub Check: core - PHP 8.4 - L11.* ↑
  • GitHub Check: stripe - PHP 8.3 - L11.* ↑ E
  • GitHub Check: admin - PHP 8.3 - L11.* ↑ E
  • GitHub Check: admin - PHP 8.3 - L12.* ↑
  • GitHub Check: core - PHP 8.3 - L11.* ↑ E
  • GitHub Check: core - PHP 8.3 - L12.* ↑
  • GitHub Check: core - PHP 8.3 - L12.* ↑ E
  • GitHub Check: core - PHP 8.3 - L11.* ↑
  • GitHub Check: fix-code-style
🔇 Additional comments (5)
docs/core/securing-your-site.md (1)

50-50: LGTM: link normalization

Trailing slash addition looks good and matches Algolia’s canonical docs URL.

docs/core/installation.md (2)

18-19: Composer constraint update to ^1.0 looks correct

Good alignment with the v1.0.0 stable release messaging elsewhere in the docs.


75-86: Good restructure: “Advanced Installation Options” + Telemetry placement

Moving Telemetry under Advanced options improves discoverability without overwhelming the core installation flow.

docs/core/upgrading.md (2)

21-29: Scout toggle guidance is clear and actionable

Good, concise explanation and example config override.


34-43: Telemetry opt‑out note reads well and matches installation guidance

Consistent with the installation page’s Telemetry section.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (8)
docs/core/contributing.md (8)

7-8: Tighten wording and fix sentence fragment.

Second sentence is a fragment; also “many different ways” is wordy and “making suggestions” is weak. Suggest a concise, single sentence.

Apply this diff:

-You can contribute to the project in many different ways. Reporting bugs, fixing bugs, helping with the documentation, 
-making suggestions and submitting improvements to the software.
+You can contribute in many ways, including reporting and fixing bugs, improving the documentation,
+proposing ideas, and submitting enhancements to the software.

25-25: Pluralization: “monorepo's” → “monorepos”.

Apostrophe indicates possession, not plural.

-However, if you're not used to working with monorepo's and setting them up inside a test Laravel application, no problem!
+However, if you're not used to working with monorepos and setting them up inside a test Laravel application, no problem!

34-36: Polish phrasing and casing (“GitHub issue”), add comma after introductory clause.

-If you find a bug in the software please raise a GitHub Issue on the 
-[lunarphp/lunar](https://github.com/lunarphp/lunar/issues) repository. Please ensure that your issue includes the 
-following:
+If you find a bug in the software, please open a GitHub issue on the
+[lunarphp/lunar](https://github.com/lunarphp/lunar/issues) repository. Please ensure your report includes the
+following:

45-45: Consistent style: lowercase “pull request” and align list punctuation.

Elsewhere you use lowercase “pull request” and list items don’t end with periods.

-- An accompanying Pull Request with a test to demonstrate the issue.
+- An accompanying pull request with a test to demonstrate the issue

60-63: Tone: replace “awesome feature” with neutral wording.

-Before you start coding away on the next awesome feature, we highly recommend starting a 
+Before you start coding a new feature, we highly recommend starting a
 [discussion](https://github.com/lunarphp/lunar/discussions) to check that your contribution will be welcomed. We would 
 hate for you to spend valuable time on something that won't be merged into Lunar.

74-79: Use “briefly” instead of “quickly” for clarity.

Minor wording improvement; keeps the meaning while reading more naturally in guidelines.

-- The title should be relevant and quickly explain what to expect inside
+- The title should be relevant and briefly explain what to expect inside

83-83: Grammar: “do so easily”.

-If you would like to contribute to the documentation you can do easily by following these instructions...
+If you would like to contribute to the documentation you can do so easily by following these instructions...

87-87: Smoother instruction phrasing.

-3. In your terminal change to the `/docs` directory
+3. Change to the `/docs` directory
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between cceeb2e and fa62aad.

📒 Files selected for processing (1)
  • docs/core/contributing.md (4 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/core/contributing.md

[style] ~7-~7: ‘many different ways’ might be wordy. Consider a shorter alternative.
Context: .... You can contribute to the project in many different ways. Reporting bugs, fixing bugs, helping w...

(EN_WORDINESS_PREMIUM_MANY_DIFFERENT_WAYS)


[style] ~7-~7: “Make” is an overused word. Consider a different verb to strengthen your wording.
Context: ... bugs, helping with the documentation, making suggestions and submitting improvements...

(MAKE_A_SUGGESTION)


[grammar] ~51-~51: There might be a mistake here.
Context: ... to get the attention it needs. :::info Be aware that creating an issue does not...

(QB_NEW_EN)


[uncategorized] ~54-~54: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...t to look into it as soon as possible. Open source code belongs to all of us, and it's all...

(EN_COMPOUND_ADJECTIVE_INTERNAL)


[style] ~60-~60: Consider using a more formal and expressive alternative to ‘awesome’.
Context: ...efore you start coding away on the next awesome feature, we highly recommend starting a...

(AWESOME)


[grammar] ~69-~69: There might be a mistake here.
Context: ...ture can be reviewed in a timely manner. If the pull request is missing informati...

(QB_NEW_EN)


[style] ~74-~74: Consider using the synonym “briefly” (= concisely, using a few words) to strengthen your wording.
Context: ...ng: - The title should be relevant and quickly explain what to expect inside - A clear...

(QUICKLY_BRIEFLY)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: search - PHP 8.4 - L12.* ↑ E
  • GitHub Check: shipping - PHP 8.4 - L12.* ↑
  • GitHub Check: shipping - PHP 8.4 - L11.* ↑
  • GitHub Check: shipping - PHP 8.4 - L11.* ↑ E
  • GitHub Check: search - PHP 8.3 - L12.* ↑ E
  • GitHub Check: admin - PHP 8.4 - L11.* ↑ E
  • GitHub Check: search - PHP 8.4 - L11.* ↑ E
  • GitHub Check: core - PHP 8.4 - L11.* ↑ E
  • GitHub Check: stripe - PHP 8.3 - L12.* ↑
  • GitHub Check: admin - PHP 8.4 - L11.* ↑
  • GitHub Check: core - PHP 8.4 - L11.* ↑
  • GitHub Check: core - PHP 8.3 - L12.* ↑
  • GitHub Check: admin - PHP 8.3 - L12.* ↑
  • GitHub Check: core - PHP 8.3 - L12.* ↑ E
  • GitHub Check: admin - PHP 8.3 - L12.* ↑ E
  • GitHub Check: admin - PHP 8.3 - L11.* ↑ E
  • GitHub Check: admin - PHP 8.3 - L11.* ↑
  • GitHub Check: core - PHP 8.3 - L11.* ↑ E
  • GitHub Check: core - PHP 8.3 - L11.* ↑
  • GitHub Check: fix-code-style
🔇 Additional comments (2)
docs/core/contributing.md (2)

68-71: Thanks for addressing the earlier grammar issue here.

The revised sentence (“it could delay progress or be closed.”) reads correctly now.


27-30: Admonition usage LGTM.

The “tip” block and link to local development setup are clear and helpful.

@glennjacobs glennjacobs merged commit 5b4aa42 into 1.x Aug 15, 2025
56 checks passed
@glennjacobs glennjacobs deleted the 1.0.0-prep branch August 15, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant