Skip to content

Bump Filament version#2268

Merged
glennjacobs merged 1 commit into1.xfrom
bump-filament
Aug 14, 2025
Merged

Bump Filament version#2268
glennjacobs merged 1 commit into1.xfrom
bump-filament

Conversation

@glennjacobs
Copy link
Contributor

@glennjacobs glennjacobs commented Aug 14, 2025 •
edited by coderabbitai bot
Loading

This is to bring in the JSON searching improvements

Summary by CodeRabbit

  • Chores
    • Updated a third-party UI/admin framework dependency to the latest patch release across the app and admin package to align with upstream maintenance updates.
    • No user-facing changes are expected; existing features and behavior should remain unchanged. This update focuses on compatibility, stability, and security with the upstream ecosystem.

@glennjacobs glennjacobs requested a review from alecritson August 14, 2025 09:49
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 14, 2025 •
edited
Loading

Walkthrough

Updated the filament/filament dependency constraint from ^3.3.31 to ^3.3.36 in the root composer.json and packages/admin/composer.json. No other dependencies or code/configuration were changed.

Changes

Cohort / File(s) Summary of changes
Root dependency bump
composer.json		 Updated require: filament/filament ^3.3.31 → ^3.3.36. No other changes.
Admin package dependency bump
packages/admin/composer.json		 Updated require: filament/filament ^3.3.31 → ^3.3.36. No other changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 60ac49f and e31a78a.

📒 Files selected for processing (2)
  • composer.json (1 hunks)
  • packages/admin/composer.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
  • GitHub Check: core - PHP 8.4 - L11.* ↑
  • GitHub Check: shipping - PHP 8.3 - L12.* ↑ E
  • GitHub Check: admin - PHP 8.3 - L12.* ↑ E
  • GitHub Check: shipping - PHP 8.3 - L12.* ↑
  • GitHub Check: admin - PHP 8.3 - L11.* ↑ E
  • GitHub Check: search - PHP 8.3 - L11.* ↑
  • GitHub Check: core - PHP 8.3 - L12.* ↑
  • GitHub Check: core - PHP 8.3 - L12.* ↑ E
  • GitHub Check: admin - PHP 8.3 - L11.* ↑
  • GitHub Check: PHP 8.4 - L^12.0 ↑
  • GitHub Check: PHP 8.4 - L^11.0 ↑
  • GitHub Check: core - PHP 8.3 - L11.* ↑
  • GitHub Check: PHP 8.3 - L^11.0 ↑
  • GitHub Check: fix-code-style
🔇 Additional comments (4)
packages/admin/composer.json (2)

18-18: Version bump looks good and matches the PR intent.
Bumping filament/filament to ^3.3.36 aligns with the stated goal (JSON searching improvements). No other constraints changed in this file.

18-18: Verify plugin compatibility & commit composer.lock — root + admin target Filament ^3.3.36

Root and packages/admin both require "filament/filament": "^3.3.36" and Packagist contains v3.3.36. However composer.lock is missing at the repo root, so we cannot confirm installed plugin versions; Packagist checks for the selected plugins show mixed Filament constraints — verify installed plugin versions before merging.

Files / findings:

  • composer.json (repo root) -> "filament/filament": "^3.3.36"
  • packages/admin/composer.json -> "filament/filament": "^3.3.36"
  • composer.lock -> NOT found at repo root (create & commit after update)

Packagist plugin observations (selected):

  • filament/spatie-laravel-media-library-plugin — listed versions do not declare a filament/filament constraint.
  • awcodes/filament-badgeable-column — some versions require ^3.0; v3.0.0 requires ^4.0 (possible incompatibility if that plugin version is used).
  • stephenjude/filament-two-factor-authentication — some versions require ^3.0.

Action items:

  • Confirm the actual plugin versions installed (composer.lock or run composer show) and ensure they are compatible with Filament 3.3.36; if a plugin version requires ^4.0, pin to a compatible release or delay the Filament upgrade.
  • After confirming, run: composer update filament/filament -W && commit composer.lock
  • Run the test suite and phpstan to catch regressions.
composer.json (2)

21-21: Root constraint bump is consistent with packages/admin.
Good to see both constraints aligned to ^3.3.36 to avoid solver conflicts in the monorepo.

21-21: Sanity-check Filament upgrade — composer.lock missing; please verify locally

I couldn't verify installed Filament versions because composer.lock was not present when I ran the check. Please run the checks locally and report results.

  • Location: composer.json (line 21)
    • Snippet: "filament/filament": "^3.3.36",
  • Run locally:
    • jq -r '.packages[]? | select(.name=="filament/filament") | .version' composer.lock || echo "composer.lock not found"
    • jq -r '.packages[]? | select(.name|test("^filament/|^awcodes/|^stephenjude/")) | [.name,.version] | @TSV' composer.lock
    • composer update filament/filament -W
    • composer test
    • composer test:phpstan
  • Also validate any Filament assets/custom themes (asset pipeline, Tailwind/build changes) between 3.3.31 → 3.3.36.

Please paste the composer.lock output or CI/test results and I will re-check.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump-filament

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel
Copy link

vercel bot commented Aug 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
lunar-docs ✅ Ready Preview Comment Aug 14, 2025 9:50am

@glennjacobs glennjacobs merged commit 0a80c4b into 1.x Aug 14, 2025
49 checks passed
@glennjacobs glennjacobs deleted the bump-filament branch August 14, 2025 13:34
@coderabbitai coderabbitai bot mentioned this pull request Aug 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alecritson alecritson alecritson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@glennjacobs @alecritson