Skip to content

Update CollectionResource.php#2249

Merged
glennjacobs merged 2 commits intolunarphp:1.xfrom
tiznull:patch-1
Aug 14, 2025
Merged

Update CollectionResource.php#2249
glennjacobs merged 2 commits intolunarphp:1.xfrom
tiznull:patch-1

Conversation

@tiznull
Copy link
Contributor

@tiznull tiznull commented Jul 20, 2025 •
edited by coderabbitai bot
Loading

We have over 15,000 collections in the main catalog. The problem with ancestors is that it shows the linear collections that are on the same level. This makes the breadcrumb 15,000+ collection names. Using CHILDREN only shows the children of the collection that you clicked into. The page loads faster and the title bar with the breadcrumb is more readable.

Please describe your Pull Request as best as possible, explaining what it provides and why it is of value, referencing any related Issues.

Try to include the following in your Pull Request, where applicable...

  • Documentation updates
  • Automated tests

Summary by CodeRabbit

  • Bug Fixes
    • Updated breadcrumb trail logic to display direct children of a collection instead of its ancestors.

@tiznull
Update CollectionResource.php
4b8f131 
We have over 15,000 collections in the main catalog. The problem with ancestors is that it shows the linear collections that are on the same level. This makes the breadcrumb 15,000+ collection names. Using CHILDREN only shows the children of the collection that you clicked into.
@vercel
Copy link

vercel bot commented Jul 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 0:23am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 20, 2025 •
edited
Loading

Walkthrough

The internal logic of the getCollectionBreadcrumbs method in the CollectionResource class was updated to iterate over a collection's children instead of its ancestors when constructing breadcrumbs. No changes were made to method signatures or public interfaces.

Changes

File Change Summary
packages/admin/src/Filament/Resources/CollectionResource.php Modified breadcrumb logic in getCollectionBreadcrumbs to iterate over children instead of ancestors.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cec97ad and 4b8f131.

📒 Files selected for processing (1)
  • packages/admin/src/Filament/Resources/CollectionResource.php (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@glennjacobs glennjacobs merged commit d1f099c into lunarphp:1.x Aug 14, 2025
47 checks passed
@wychoong
Copy link
Contributor

wychoong commented Dec 1, 2025

@glennjacobs @alecritson I think this change is broken. Breadcrumbs should diplay ancestors not childs

before this PR
image

after
image

image

this is the collection structure tree
image

this PR supposed to fix issue with 15,000+ collections slowness, but I do not understand how is this solving that when the change here is about the nested levels of collection
@tiznull can you please explain how is this fix your issue or can you provide a repo with the 15,000 collection seeder

@glennjacobs glennjacobs mentioned this pull request Dec 1, 2025
Closed
@alecritson alecritson mentioned this pull request Dec 5, 2025
Merged
glennjacobs pushed a commit that referenced this pull request Dec 8, 2025
@alecritson
Revert breadcrumbs back to ancestors (#2364)
cbae3b0 
PR to revert #2249 as this is seems to have broken breadcrumbs on
collections. Suggest we have a look at performance in more depth as the
collection tree will also stall if you have over 1k collections in a
group, suggesting there is a bigger issue at player with that.

Closes #2360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glennjacobs glennjacobs glennjacobs approved these changes

@alecritson alecritson alecritson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiznull @wychoong @glennjacobs @alecritson