Skip to content

Fix InvalidArgument in shipping options DTO#2243

Merged
glennjacobs merged 3 commits into1.xfrom
hotfix_shipping_options
Jul 16, 2025
Merged

Fix InvalidArgument in shipping options DTO#2243
glennjacobs merged 3 commits into1.xfrom
hotfix_shipping_options

Conversation

@glennjacobs
Copy link
Contributor

@glennjacobs glennjacobs commented Jul 14, 2025

Not sure why we were using Doctrine\Common\Cache\Psr6\InvalidArgument;, I don't believe it's an exception that's supposed to be used externally to the package. It also no longer exists in the latest version.

Summary by CodeRabbit

  • Refactor
    • Updated internal error handling to improve reliability when processing shipping options. No changes to user-facing features.

@vercel
Copy link

vercel bot commented Jul 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 4:56pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 14, 2025

Walkthrough

The import of the exception class in ShippingOptionLookup was changed from a Doctrine cache-related exception to the built-in PHP InvalidArgumentException. The throw_if call in the constructor was updated to use the exception class name string instead of an instantiated exception object.

Changes

File(s) Change Summary
packages/table-rate-shipping/src/DataTransferObjects/ShippingOptionLookup.php Changed exception import to PHP's InvalidArgumentException and updated throw_if to use class name string instead of instance.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b08ab7b and 64758b3.

📒 Files selected for processing (1)
  • packages/table-rate-shipping/src/DataTransferObjects/ShippingOptionLookup.php (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/table-rate-shipping/src/DataTransferObjects/ShippingOptionLookup.php
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 290c8ef and 44e29f7.

📒 Files selected for processing (1)
  • packages/table-rate-shipping/src/DataTransferObjects/ShippingOptionLookup.php (1 hunks)
🧰 Additional context used
🪛 GitHub Check: PHP 8.4 - L^12.0 ↑
packages/table-rate-shipping/src/DataTransferObjects/ShippingOptionLookup.php

[failure] 21-21:
Class Doctrine\Common\Cache\Psr6\InvalidArgument not found.

🪛 GitHub Check: PHP 8.3 - L^12.0 ↑
packages/table-rate-shipping/src/DataTransferObjects/ShippingOptionLookup.php

[failure] 21-21:
Class Doctrine\Common\Cache\Psr6\InvalidArgument not found.

🪛 GitHub Check: PHP 8.3 - L^11.0 ↑
packages/table-rate-shipping/src/DataTransferObjects/ShippingOptionLookup.php

[failure] 21-21:
Class Doctrine\Common\Cache\Psr6\InvalidArgument not found.

🪛 GitHub Check: PHP 8.4 - L^11.0 ↑
packages/table-rate-shipping/src/DataTransferObjects/ShippingOptionLookup.php

[failure] 21-21:
Class Doctrine\Common\Cache\Psr6\InvalidArgument not found.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
  • GitHub Check: admin - PHP 8.4 - L12.* ↑
  • GitHub Check: shipping - PHP 8.4 - L12.* ↑
  • GitHub Check: shipping - PHP 8.4 - L11.* ↑ E
  • GitHub Check: core - PHP 8.4 - L12.* ↑ E
  • GitHub Check: core - PHP 8.4 - L12.* ↑
  • GitHub Check: admin - PHP 8.4 - L12.* ↑ E
  • GitHub Check: admin - PHP 8.4 - L11.* ↑ E
  • GitHub Check: search - PHP 8.3 - L11.* ↑ E
  • GitHub Check: shipping - PHP 8.3 - L12.* ↑
  • GitHub Check: core - PHP 8.4 - L11.* ↑
  • GitHub Check: admin - PHP 8.3 - L12.* ↑ E
  • GitHub Check: admin - PHP 8.3 - L12.* ↑
  • GitHub Check: core - PHP 8.3 - L11.* ↑
  • GitHub Check: core - PHP 8.3 - L12.* ↑
  • GitHub Check: admin - PHP 8.3 - L11.* ↑
  • GitHub Check: core - PHP 8.3 - L12.* ↑ E
  • GitHub Check: admin - PHP 8.3 - L11.* ↑ E
  • GitHub Check: core - PHP 8.3 - L11.* ↑ E
  • GitHub Check: fix-code-style
🔇 Additional comments (2)
packages/table-rate-shipping/src/DataTransferObjects/ShippingOptionLookup.php (2)

5-5: Verify the import statement

The import use Doctrine\Common\Cache\Psr6\InvalidArgument; appears to be incorrect based on the static analysis failures. This namespace suggests a PSR-6 cache-specific exception rather than a general invalid argument exception.

Consider replacing with:

-use Doctrine\Common\Cache\Psr6\InvalidArgument;
+use InvalidArgumentException;

And then update line 21 to:

-InvalidArgument::class
+InvalidArgumentException::class

17-22: Approve the throw_if usage pattern

The change from new InvalidArgument to InvalidArgument::class is syntactically correct for Laravel's throw_if helper function. This pattern allows Laravel to instantiate the exception with a default message when the condition is met.

@glennjacobs glennjacobs merged commit cec97ad into 1.x Jul 16, 2025
3 checks passed
@glennjacobs glennjacobs deleted the hotfix_shipping_options branch July 16, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants