Skip to content

Feature/dashboard metrics#1

Merged
alecritson merged 4 commits intomainfrom
feature/dashboard-metrics
Dec 22, 2021
Merged

Feature/dashboard metrics#1
alecritson merged 4 commits intomainfrom
feature/dashboard-metrics

Conversation

@alecritson
Copy link
Collaborator

Added an initial attempt to get the dashboard working.

@alecritson alecritson merged commit 2e97da0 into main Dec 22, 2021
@alecritson alecritson deleted the feature/dashboard-metrics branch December 22, 2021 13:26
glennjacobs added a commit that referenced this pull request Dec 18, 2023
Move everything into /packages folder
glennjacobs pushed a commit that referenced this pull request May 28, 2024
Fix error `get_class(): Argument #1 ($object) must be of type object,
null given`

this happens when added a new attribute to a resource.
the fix
7b19a0e
is to mutate the state during field dehydration to return new field type
instance when state is null
`formatStateUsing` doesnt set the instance during field hydration as it
only apply when the state is not null

other commits are some inconsistency that I found while troubleshooting,
it should still works without those commits
samimhamza added a commit to nawawaran/lunar that referenced this pull request Mar 17, 2025
glennjacobs pushed a commit that referenced this pull request Aug 17, 2025
…2274)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Corrected breadcrumb navigation in the Product Variant admin area.
When managing variant identifiers, the final breadcrumb now links to the
Identifiers page instead of Inventory, aligning with the page context.
This improves navigation accuracy and consistency across the admin
interface, reducing confusion for users. No changes to data or
functionality—only the breadcrumb destination was updated wherever this
breadcrumb appears.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Beaudinn added a commit to print4sign/lunar-base that referenced this pull request Jan 12, 2026
…ents

This commit addresses 6 important issues identified in the comprehensive code review:

Issue lunarphp#1: Artwork URL TTL (60s → 3600s)
- Changed temporary URL expiration from 60 seconds to 3600 seconds (1 hour)
- Updated HelloPrintDriver::getArtworkUrl()
- Updated PrintComDriver::getArtworkUrl()
- Prevents premature URL expiration during order submission

Issue lunarphp#2: Internal Supplier Seeder Command
- Created lunar:seed-internal-supplier artisan command
- Registered command in LunarServiceProvider
- Makes InternalSupplierSeeder easily runnable without modifying DatabaseSeeder

Issue lunarphp#3: Supplier Product Validation
- Added validation in HelloPrintDriver::submitOrder()
- Added validation in PrintComDriver::submitOrder()
- Returns OrderResponse::failed() if variant has no supplier product
- Prevents null reference exceptions during order submission

Issue lunarphp#4: PrintCom Sandbox Mode
- Added sandbox configuration to suppliers.php for PrintCom
- Added PRINTCOM_SANDBOX environment variable support
- Updated PrintComDriver::submitOrder() to include mode field (test/live)
- Matches HelloPrint driver pattern for consistency

Issue lunarphp#5: Meta Array Handling
- Standardized meta array handling in GetPrintComPrice pipeline
- Fixed potential array offset error when meta is null
- Properly initializes meta array before setting supplier_pricing

Issue lunarphp#6: Foreign Key Indexes
- Added explicit indexes for foreign key columns in supplier_orders table
- Added indexes for cancellation_requested_by, cancelled_by, approved_by
- Improves query performance for user-related lookups
- Added corresponding dropIndex calls in migration down() method

All changes are backward compatible and include proper test coverage.
Tests passing: 50 passed (175 assertions)

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants