Skip to content

fix: allow bigint in typings#96

Merged
lukeed merged 1 commit into
lukeed:masterfrom
ViliamKopecky:master
Apr 23, 2024
Merged

fix: allow bigint in typings#96
lukeed merged 1 commit into
lukeed:masterfrom
ViliamKopecky:master

Conversation

@ViliamKopecky

@ViliamKopecky ViliamKopecky commented Apr 15, 2024

Copy link
Copy Markdown
Contributor

ReactNode from @types/react now includes bigint (and its 0n zero which is falsy) and that is incompatible with clsx in these scenarios:

declare const x: ReactNode

const className = clsx(x && 'some-class')
// Argument of type 'false | "" | 0 | 0n | "some-class" | null | undefined' is not assignable to parameter of type 'ClassValue'.
//  Type '0n' is not assignable to type 'ClassValue'.

@Netail Netail mentioned this pull request Apr 17, 2024
Closed
@lukeed

lukeed commented Apr 18, 2024

Copy link
Copy Markdown
Owner

Thanks! I’ll merge and publish tomorrow. Traveling for work right now & haven’t had a chance to open laptop

@lukeed
lukeed merged commit 3d960ab into lukeed:master Apr 23, 2024
@lukeed

lukeed commented Apr 23, 2024

Copy link
Copy Markdown
Owner

Included in 2.1.1

@snyk-io snyk-io Bot mentioned this pull request May 22, 2024
Open
@vigneshshettyin vigneshshettyin mentioned this pull request May 27, 2024
Merged
@thomassimmer thomassimmer mentioned this pull request May 27, 2024
Open
@rong4ivy rong4ivy mentioned this pull request Jun 8, 2024
Open
@JuanPabloDiaz JuanPabloDiaz mentioned this pull request Jun 18, 2024
Merged
@rsaz rsaz mentioned this pull request Jul 6, 2024
Closed
@angeloreale angeloreale mentioned this pull request Jul 14, 2024
Merged
@filipeoliveiraa filipeoliveiraa mentioned this pull request Aug 4, 2024
Closed
This was referenced Aug 8, 2024
Closed
Merged
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
@salgadev salgadev mentioned this pull request Sep 1, 2024
Open
@zntb zntb mentioned this pull request Sep 14, 2024
Merged
@wierza wierza mentioned this pull request Sep 30, 2024
Open
@Sawsqr68

Sawsqr68 commented Oct 17, 2025

Copy link
Copy Markdown

<span class:list={[ 'hello goodbye', { world: true }, [ 'friend' ] ]} />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ViliamKopecky @lukeed @Sawsqr68