Fix the readme’s first link to benchmarks#82
Merged
Conversation
acusti
changed the title
Owner
|
Oh bummer. This might have been an unintended change in the last batch of GH readme updates thanks for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for some reason, the
fasterlink at the top of the README in the description block gets interpreted as pointing togithub.com/bench. making it a fully relative link (no leading slash) fixes that issue.here’s a link to the readme file showing the bad link URL resolution on
master: https://github.com/lukeed/clsx/blob/master/readme.mdand here’s a link to the readme file in the same GitHub view but from this branch: https://github.com/acusti/clsx/blob/patch-1/readme.md
oh yes, and thank you so much for this package! it’s such a wonderful asset for the community.