This repository was archived by the owner on Dec 15, 2018. It is now read-only.
Implement From trait for finch #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out the
Fromtrait, andfinchseemed like a good first try (since I can check if the implementations are compatible).pinging @bovee just to make sure I interpreted the
finchstruct correctly: in sourmash we keep the abundance of a k-mer, but finch usescountandextra_count. What is the difference between them, and can I just sum them up to have the total count?The other thing was figuring out what is the k-mer length, since this is not saved in the struct. I solved this by checking the first value from
.into_vec()