Repository navigation
feat(svelte): export __iconData and __iconNode across per-icon modules (#4936) - #4957
Merged
ericfennis merged 9 commits intoOct 19, 2026
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
…a flag - Problem: generateAliasesFiles unconditionally re-exported __iconData and __iconNode for all packages using separateAliasesFile. Packages like @lucide/solid and @lucide/icons do not export these names from their templates, causing missing export errors in downstream bundlers (e.g. solid vite integration). - Solution: Add exportIconData flag (default false) to CLI, generateIconFiles, and generateAliasesFiles so named re-exports are opt-in and only emitted for packages that define them (@lucide/svelte).
ericfennis
requested changes
Oct 15, 2026
ericfennis
left a comment
Member
There was a problem hiding this comment.
I like the overal changes.
But I don't like the changes in tools/build-icons/* can you remove these?
Contributor
Author
|
Done @ericfennis! Completely reverted all changes in |
ericfennis
approved these changes
Oct 19, 2026
brandhaug
added a commit
to brandhaug/b2b-saas-starter
that referenced
this pull request
Oct 23, 2026
## pnpm-workspace.yaml (default) ## Dependency Updates | Package | From | To | Type | | --- | --- | --- | --- | | `lucide-react` | 1.59.0 | 1.60.0 | minor | ## Release Notes <details> <summary><b>lucide-react</b> (1.59.0 → 1.60.0)</summary> ## What's Changed * feat(icons): added `tombstone` icon by @<!---->ryck in lucide-icons/lucide#4929 * feat(icons): added `smartphone-user-round` icon by @<!---->hitanshu-machhi in lucide-icons/lucide#4586 * feat(icons): added `bacon` icon by @<!---->devkamani9313-lab in lucide-icons/lucide#4694 * fix(site): Fix build by @<!---->ericfennis in lucide-icons/lucide#5033 * chore(docs): Update icon count comparison with Feather Icons by @<!---->noahweidig in lucide-icons/lucide#5022 * feat(icons): added `letter-spacing` icon by @<!---->madebyoz in lucide-icons/lucide#3038 * chore(deps): bump the vue-deps group with 2 updates by @<!---->dependabot[bot] in lucide-icons/lucide#5027 * chore(deps-dev): bump react-native from 0.87.1 to 0.88.0 in the react-native-deps group by @<!---->dependabot[bot] in lucide-icons/lucide#5030 * feat(icons): added `line-height` icon by @<!---->madebyoz in lucide-icons/lucide#3039 * chore(deps-dev): bump the svelte-deps group across 1 directory with 2 updates by @<!---->dependabot[bot] in lucide-icons/lucide#5028 * chore(deps): bump the react-deps group across 1 directory with 2 updates by @<!---->dependabot[bot] in lucide-icons/lucide#5026 * feat(icons): added `brain-off` icon by @<!---->ej52 in lucide-icons/lucide#3535 * feat(icons): added `graph-hub` icon by @<!---->Carlito-la-banane in lucide-icons/lucide#4974 * feat(svelte): export __iconData and __iconNode across per-icon modules (#4936) by @<!---->ronitgupta138 in lucide-icons/lucide#4957 ## New Contributors * @<!---->hitanshu-machhi made their first contribution in lucide-icons/lucide#4586 * @<!---->devkamani9313-lab made their first contribution in lucide-icons/lucide#4694 * @<!---->noahweidig made their first contribution in …[full notes](https://github.com/lucide-icons/lucide/releases/tag/1.60.0) </details> --- *This PR was auto-generated by [catalog-update-action](https://github.com/brandhaug/catalog-update-action).* Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 of 14 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Problem
Follow-up to #4644 and #4761.
While
lucide-react,lucide-preact,lucide-solid, andlucide-react-nativeexport__iconDataand__iconNodefrom individual icon modules,@lucide/sveltepreviously inlinediconDataprivately within its instance script, leaving consumers and animation/morphing tools without a way to access raw icon geometry directly from@lucide/svelte/icons/*.Solution
__iconDataand__iconNodein<script module lang="ts">: Updatedpackages/svelte/scripts/exportTemplate.mtsto declare__iconData: LucideIconDataand deprecated__iconNode: LucideIconNode[]inside the module script so they are exported as real, tree-shakeable module exports.tools/build-icons/building/generateIconFiles.tsandtools/build-icons/building/aliases/generateAliasesFiles.tsso that separate icon shims (dist/icons/*.jsanddist/icons/*.d.ts) re-export{ default, __iconData, __iconNode }.Testing
packages/svelte/tests/lucide-svelte.spec.tsverifying that__iconDataand__iconNodeare exported and match the icon's node definition.@lucide/svelte.svelte-checkand full package builds (0 errors, 0 warnings).Fixes #4936.