Add Subscript icon #459
Merged
Add Subscript icon #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericfennis
requested changes
Dec 27, 2021
Member
ericfennis
left a comment
ericfennis
left a comment
There was a problem hiding this comment.
Nice work, small optimisations for the code to make it smaller
Co-authored-by: Eric Fennis <[email protected]>
Contributor
Author
|
Thanks. I will optimize in future |
Contributor
Author
|
Is there something else for me to do so that this pr can be merged? |
Member
|
@ericfennis Should we also add "math" tag? |
Member
|
@mittalyashu I'm not exactly sure what you mean. Not the sigma (SUM) icon right? |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscript icon
Icon request
Closes #431
Original icon request from feather
feathericons/feather#511 (comment)