Skip to content

Add verified icon #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericfennis merged 3 commits into from
Oct 3, 2021
Merged

Add verified icon #416

ericfennis merged 3 commits into from
Oct 3, 2021

Conversation

@siarie
Copy link
Contributor

@siarie siarie commented Oct 2, 2021

Preview

2021-10-02-202717_493x426_scrot

@ericfennis
Copy link
Member

ericfennis commented Oct 2, 2021

@siarie Awesome icon! Thanks for this contribution!

ericfennis
ericfennis reviewed Oct 2, 2021
View reviewed changes
icons/verified.svg Outdated
stroke-linecap="round"
stroke-linejoin="round"
>
<path d="M11.997 3a3.599 3.599 0 00-3.044 1.682 3.599 3.599 0 00-.908-.095 3.599 3.599 0 00-2.411 1.051 3.6 3.6 0 00-.947 3.318A3.6 3.6 0 003 12.004a3.6 3.6 0 001.69 3.047 3.6 3.6 0 00.947 3.315 3.599 3.599 0 003.352.96A3.599 3.599 0 0012.002 21a3.599 3.599 0 003.037-1.671 3.599 3.599 0 004.295-4.297A3.6 3.6 0 0021 11.998a3.6 3.6 0 00-1.67-3.035v-.002a3.599 3.599 0 00-4.298-4.292A3.599 3.599 0 0011.997 3z" />
Copy link
Member

@ericfennis ericfennis Oct 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With SVGOMG I was able to minify it a bit.

Suggested change
<path d="M11.997 3a3.599 3.599 0 00-3.044 1.682 3.599 3.599 0 00-.908-.095 3.599 3.599 0 00-2.411 1.051 3.6 3.6 0 00-.947 3.318A3.6 3.6 0 003 12.004a3.6 3.6 0 001.69 3.047 3.6 3.6 0 00.947 3.315 3.599 3.599 0 003.352.96A3.599 3.599 0 0012.002 21a3.599 3.599 0 003.037-1.671 3.599 3.599 0 004.295-4.297A3.6 3.6 0 0021 11.998a3.6 3.6 0 00-1.67-3.035v-.002a3.599 3.599 0 00-4.298-4.292A3.599 3.599 0 0011.997 3z" />
<path d="M12 3a3.6 3.6 0 0 0-3.05 1.68 3.6 3.6 0 0 0-.9-.1 3.6 3.6 0 0 0-2.42 1.06 3.6 3.6 0 0 0-.94 3.32A3.6 3.6 0 0 0 3 12a3.6 3.6 0 0 0 1.69 3.05 3.6 3.6 0 0 0 .95 3.32 3.6 3.6 0 0 0 3.35.96A3.6 3.6 0 0 0 12 21a3.6 3.6 0 0 0 3.04-1.67 3.6 3.6 0 0 0 4.3-4.3A3.6 3.6 0 0 0 21 12a3.6 3.6 0 0 0-1.67-3.04v0a3.6 3.6 0 0 0-4.3-4.3A3.6 3.6 0 0 0 12 3z"/>

Copy link
Contributor Author

@siarie siarie Oct 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah. I forgot about that.
Anyway, can you guide me how to use SVGO? I wanted to try it myself, but the result was different from what you suggested.

@siarie
Copy link
Contributor Author

siarie commented Oct 3, 2021

Hmm, 🤔. Looks like I got something wrong.
I forgot about point 2 in ICON-DESIGN-GUIDE

  1. Icons must have a 1 pixel padding within the canvas.

But I see many icons have 2 pixel padding (and even 3 pixel). So, which one is correct?
Though, the guide says 1px. But before I fix it, I wanna hear your opinions.

cc: @ericfennis, @locness3

@ericfennis
Copy link
Member

ericfennis commented Oct 3, 2021

@siarie I understand your confusion. I think we need to update the text a bit. It should be "Icons must have at least 1 pixel padding within the canvas.". We want a least 1 pixel empty around the canvas to make sure icons will render nicely. Otherwise some icons will look like they are "cut off".

There are still icons which don't have the 1 pixel padding. They still need to be refactored

ericfennis
ericfennis approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this icon you made is fine!

ericfennis added a commit that referenced this pull request Oct 3, 2021
@ericfennis
Update the text a bit to avoid confusion, #416
4c868c9
@moeenio
Copy link
Contributor

moeenio commented Oct 3, 2021

It's 1px minimum.

@ericfennis ericfennis merged commit e27d114 into lucide-icons:master Oct 3, 2021
@siarie siarie deleted the icons/verified branch October 3, 2021 11:37
@moeenio
Copy link
Contributor

moeenio commented Oct 3, 2021

Oh, the name...

@siarie
Copy link
Contributor Author

siarie commented Oct 3, 2021

Oh, the name...

Hmm?. Did you mean this PR?
The name piggy-bank-.svg caused build error. @locness3

@moeenio
Copy link
Contributor

moeenio commented Oct 3, 2021

wth

I meant verified is not the kind of name I'd put in lucide. How would you call the outer shape of this icon?

@siarie
Copy link
Contributor Author

siarie commented Oct 3, 2021

Well, I can't think of any other name other than this.
I saw bootstrap using the name patch-check and fontawesome using badge-check. Do you have any suggestion?

How would you call the outer shape of this icon?

I don't know.

@moeenio
Copy link
Contributor

moeenio commented Oct 3, 2021

badge-check seems fitting to me.

@karsa-mistmere karsa-mistmere mentioned this pull request Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericfennis ericfennis ericfennis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siarie @ericfennis @moeenio