feat(icons): added sport-shoe icon#3953
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "contributors": [ | ||
| "Youya-ui" | ||
| ], | ||
| "tags": [ |
There was a problem hiding this comment.
Suggestions for the sport-shoe icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:
| "tags": [ | |
| "tags": [ | |
| "jogging", | |
| "sneakers", | |
| "gear", | |
| "outdoor", |
Added or changed iconsPreview cohesion   Preview stroke widths  DPI Preview16px (shadcn/ui)
24px (default)
32px (shadcn/ui + retina)
48px (default + retina)
Icon X-rays
Icon Diffs
Icon SymmetryFlip Horizontal
Flip Vertical
Flip Diagonal
Rotate 180°
Icons as codeWorks for: const SportShoeIcon = createLucideIcon('SportShoe', [
["path",{"d":"m15 10.42 4.8-5.07"}],
["path",{"d":"M19 18h3"}],
["path",{"d":"M9.5 22 21.414 9.415A2 2 0 0 0 21.2 6.4l-5.61-4.208A1 1 0 0 0 14 3v2a2 2 0 0 1-1.394 1.906L8.677 8.053A1 1 0 0 0 8 9c-.155 6.393-2.082 9-4 9a2 2 0 0 0 0 4h14"}]
]) |
karsa-mistmere
left a comment
karsa-mistmere
left a comment
There was a problem hiding this comment.
Hey @Youya-ui,
How exactly is this different from #3846?
Other than that, I'm afraid this design is not yet fully compliant with our design guidelines, I guess the most severe issues would be:
- Some sharp corners require additional rounding
- The sole doesn't have the necessary 2px gap between its confining paths
- The cubic curve path segments could do with better curvature, and we should probably consider converting some of them to grid-aligned arcs
|
Thanks for the feedback @karsa-mistmere ! About #3846: It was indeed the same icon. I closed it and re-submitted via the Studio because I initially thought something was wrong with my original PR (workflows not running, branch naming differing from other PRs, etc.). Sorry for the confusion — this PR is meant to replace that one, not duplicate it. About your review comments:
Please let me know if there are any specific areas you'd like me to refine further. 
|
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
I like a full sole line |
jguddas
left a comment
jguddas
left a comment
There was a problem hiding this comment.
Does not follow guidelines, gap, roundness…
@jguddas I see nothing major, what exact issues do you think need to be addressed? |
Less than 2px gap, also quite sharp corners. |
Ah, my bad, I thought this was the latest version: This is the version I think we should go with, it's the most Lucide-ey one imo. |
4 participants
What is the purpose of this pull request?
Description
Added new
sport-shoeicon representing athletic footwear in motion.Icon use case
Alternative icon designs
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json.Design
Before Submitting