Skip to content

Add quote icon #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericfennis merged 2 commits into from
Sep 6, 2021
Merged

Add quote icon #389

ericfennis merged 2 commits into from
Sep 6, 2021

Conversation

@Billiam
Copy link
Contributor

@Billiam Billiam commented Aug 25, 2021 •
edited
Loading

  • Name of the icon : quote
  • Tags (alternative names for this icon) (add them in tags.json) : quotation
  • What is the purpose of this icon? : Likely used as a button alongside bold/italic/strikethrough to indicate block quoting
  • 100% scale preview : quote
  • Have you considered alternative possibilities for its naming or design? : I tried a few versions with rounded tops and softer curves at the tip, but it ends up looking like a '99' very quickly. I think this is a good balance

I saw this was in the feather PR / issue list, and I needed it for my own project.

@Billiam
Copy link
Contributor Author

Billiam commented Aug 25, 2021

Side note on the PR template:

  • Unlike issue templates, you can't use named pull request templates without using a query string URL (ex: ?template=new-icon.md). I think you can use .github/pull_request_template.md if you don't need multiple templates, but it'll appear for everybody.
  • YML metadata is ignored and just ends up in the issue body

@ericfennis
Copy link
Member

ericfennis commented Aug 25, 2021

@Billiam Thanks for opening, and welcome to the community.

I'm curious how it will look next to the other text editing icons.

@Billiam
Copy link
Contributor Author

Billiam commented Aug 25, 2021

I'm curious how it will look next to the other text editing icons.

Screenshot_20210825_170107

A bit like this. While it's not a great match for the text icons (since they're relatively thin and open), I think it fits in well with icons like 'image' and 'table'

ericfennis
ericfennis reviewed Sep 5, 2021
View reviewed changes
@ericfennis ericfennis merged commit 66b3574 into lucide-icons:master Sep 6, 2021
@karsa-mistmere karsa-mistmere mentioned this pull request Jun 15, 2022
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericfennis ericfennis ericfennis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Billiam @ericfennis