fix(site): Small adjustments color picker and add clear button search bar #3851
+302
−221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karsa-mistmere
requested changes
Dec 8, 2025
| set: (val) => emit('update:modelValue', val) | ||
| }) | ||
| get: () => { | ||
| if (props.modelValue === 'currentColor') { |
Member
There was a problem hiding this comment.
How about?
Suggested change
| if (props.modelValue === 'currentColor') { | |
| if (!props.modelValue || props.modelValue === 'currentColor') { |
Member
Author
There was a problem hiding this comment.
This can be annoying if you want to clear the field. But we can make it explicit.
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Add check if value is undefined or null
Co-authored-by: Karsa <[email protected]>
karsa-mistmere
approved these changes
Dec 11, 2025
karsa-mistmere
added a commit
that referenced
this pull request
Dec 12, 2025
… bar (#3851) * Small adjustments * Format code * format code * Remove default value * format code * update yml file * Format code * Update docs/.vitepress/theme/components/base/Input.vue Co-authored-by: Karsa <[email protected]> * Add extra check if null or undefined --------- Co-authored-by: Karsa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjustments site